Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not give Electron accelerators that change with keyboard layout under Mac/Linux #1369

Closed
alexdima opened this issue Dec 16, 2015 · 1 comment
Closed

Do not give Electron accelerators that change with keyboard layout under Mac/Linux #1369

alexdima opened this issue Dec 16, 2015 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
Dec 2015

Comments

@alexdima
Copy link
Member

The reason is the menu where they fail to render them correctly + on the mac they dispatch incorrectly
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2015
@alexdima alexdima self-assigned this Dec 16, 2015
@alexdima alexdima added this to the Dec 2015 milestone Dec 16, 2015
@alexdima
Copy link
Member Author

Steps:

  • switch to different keyboard layout (e.g. German-Swiss)
  • close and reopen code
  • top level menu & context menu should either render what you need to actually press or nothing at all

Note: under windows Electron does the right thing and only mac & linux are really impacted

@alexdima alexdima assigned bpasero and unassigned alexdima Dec 16, 2015
@bpasero bpasero added the verified Verification succeeded label Dec 17, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
Dec 2015
Development

No branches or pull requests
2 participants
@bpasero @alexdima