Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple language specific settings #138076

Closed
3 tasks done
sandy081 opened this issue Nov 29, 2021 · 1 comment
Closed
3 tasks done

Test multiple language specific settings #138076

sandy081 opened this issue Nov 29, 2021 · 1 comment

Comments

@sandy081
Copy link
Member

sandy081 commented Nov 29, 2021

Ref #51935

Complexity: 3

Create Issue


You can now configure editor settings for multiple languages once as follows (in your settings):

"[cpp][c]":{
    "editor.formatOnSave": true
}
  • Test that these settings are applied to all configured languages
  • Test that settings are merged for a language, when the language is configured multiple times with different languages. Eg:
"[cpp][c]":{
    "editor.formatOnSave": true
},
"[java][c]":{
    "editor.lineHeight": 2.5
}

In the above example, c language shall have following overrides after merging

{
    "editor.formatOnSave": true,
      "editor.lineHeight": 2.5
}
  • Test that settings configured with single language only are preferred when the language is configured multiple times with different languages. Eg:
"[c]":{
   "editor.formatOnSave": false
},
"[cpp][c]":{
    "editor.formatOnSave": true
},
"[java][c]":{
    "editor.lineHeight": 2.5
},

In the above example, c language shall have following overrides after merging

{
    "editor.formatOnSave": false,
      "editor.lineHeight": 2.5
}
  • Explore and test various other scenarios which you can try
@sandy081 sandy081 added this to the November 2021 milestone Nov 29, 2021
@ghost ghost assigned lramos15, karrtikr and isidorn Nov 30, 2021
@karrtikr karrtikr removed their assignment Nov 30, 2021
@isidorn
Copy link
Contributor

isidorn commented Nov 30, 2021

We now support language specific settings and we also support to specify multiple languages. This is nice, but is hard to be discovered by the users because this is not available in the Settings UI.

I think we should drive settings feature the other way around, starting from the Settings UI. Because if the settings UI does not support it 95% of our users will simply not find the feature.

@rzhao271 that is why I think we should work on #74195 and #58995

@isidorn isidorn removed their assignment Nov 30, 2021
@lramos15 lramos15 removed their assignment Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants