Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Release only extensions show up in Stable search results #138231

Closed
JacksonKearl opened this issue Dec 1, 2021 · 2 comments
Closed

Pre-Release only extensions show up in Stable search results #138231

JacksonKearl opened this issue Dec 1, 2021 · 2 comments
Assignees
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone

Comments

@JacksonKearl
Copy link
Contributor

I created a new test-Stable build off of the same commit as todays Insiders to help test #138068: https://az764295.vo.msecnd.net/insider/4ee3ed1ff239dd9b51cd07ed8a35e29ca9d441c2/VSCode-darwin.zip

In it I see that the extension which I've only published a pre-release version of shows up in the search results, even though trying to install it gives the same issue as reported in #138215.

IMO in this case it either shouldn't show up at all, or at least should say "Install Pre-Release" instead of "Install" (and "Install Pre-Release" should work to correctly install the pre-release)

image

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2021

This is a known limitation and we are building this feature based on properties we define and not on semver which is not yet supported by Marketplace. Hence, not showing an extension which does not have pre-release is not possible.

Once Marketplace supports Semver then it can enhance the Query API to provide pre-release filters. For eg., then we can add a filter that client does not prefer pre-releases and the query can return results accordingly.

But, I can try if I can show Install Pre-release action as default action in this case.

CC @isidorn - lets have a note of this we MP supports Semver.

@sandy081 sandy081 added extensions Issues concerning extensions polish Cleanup and polish issue labels Dec 1, 2021
@sandy081 sandy081 added this to the November 2021 milestone Dec 1, 2021
@isidorn
Copy link
Contributor

isidorn commented Dec 1, 2021

This will not happen in practice, no extensions will only have the Pre-Release version - this defeats the purpose.
Showing the correct action label is a good enough fix for this imho

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

4 participants
@isidorn @JacksonKearl @sandy081 and others