Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release info is shown in two locations #138262

Closed
weinand opened this issue Dec 1, 2021 · 4 comments
Closed

Pre-release info is shown in two locations #138262

weinand opened this issue Dec 1, 2021 · 4 comments
Assignees
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Dec 1, 2021

Testing #138068

The existence of a pre-release version is shown in two locations:

image

IMO moving the "Switch to.." button down to the "This extension has a Pre-Release version" message would simplify the UI (and would make the "pre-release" become more prominent in the UI)

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2021

Here is the latest UI

image

This is as per our initial UX design and I like that the buttons are all together like in the tool bar. Another option would be to remove the message The extension has Pre-Release version available because Switch to Pre-Release Version button is obvious that the extension has a pre-release.

CC @isidorn @misolori

@sandy081 sandy081 added extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach labels Dec 1, 2021
@weinand
Copy link
Contributor Author

weinand commented Dec 2, 2021

If we want to keep the "sea of buttons" then lets drop the additional message.

@sandy081 sandy081 added this to the November 2021 milestone Dec 2, 2021
@sandy081 sandy081 added polish Cleanup and polish issue and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 2, 2021
@sandy081
Copy link
Member

sandy081 commented Dec 2, 2021

Removed the pre-release text in the editor given that the button conveys the message and also reduces the clutter of messages in the editor.

@isidorn
Copy link
Contributor

isidorn commented Dec 2, 2021

Thanks @sandy081
Makes sense to remove the duplication. I like keeping the 3 buttons, there is enough space and the clutter is not that bad.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

4 participants
@weinand @isidorn @sandy081 and others