Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension search by file extension (ext:) also matches against tags #140050

Closed
digitarald opened this issue Jan 3, 2022 · 7 comments
Closed

Extension search by file extension (ext:) also matches against tags #140050

digitarald opened this issue Jan 3, 2022 · 7 comments
Assignees
Labels
extension-recommendations Extension recommendations issues extensions Issues concerning extensions

Comments

@digitarald
Copy link
Contributor

Spin-off from #139321 (comment).

ext:production is converted this following tags filters: __ext_production, __ext_.production, production. MP is returning all extensions that contain at least one of these tags.

I suggest to audit if broadening the extension query to tags is more helpful (extensions that have defined the relevant tags but not file extension) or counter-productive (extensions are shown that have nothing to do with the searched file extension).

In case of the linked issue, I see it as more harmful. If there is no common cases where it helps to find the right extensions, I would recommend to make the query less broad by not including tags.

@sandy081
Copy link
Member

sandy081 commented Jan 4, 2022

I would appreciate if there are any constructive recommendations or suggestions.

@isidorn isidorn added the info-needed Issue requires more information from poster label Jan 7, 2022
@isidorn
Copy link
Contributor

isidorn commented Jan 7, 2022

@digitarald do you have some suggestions on how to improve this? I do not unfortunetly.
We can also keep the discussion in #139321

@digitarald
Copy link
Contributor Author

@digitarald do you have some suggestions on how to improve this? I do not unfortunetly.

My recommendation would be to just search in the extension fields, but not including the tag in the search, so resolving ext:example is resolved into __ext_example, __ext_.example, but not adding example (using the format from the original comment #139321 (comment)).

As I am not 100% familiar with the format of the marketplace search, did I capture the idea in a sensible format, @sandy081?

@sandy081
Copy link
Member

I am not sure what will we miss if example tag is excluded in this case. Will there be an extension with this tag that supports this language? Actually I do not know why this was like this as it was there from beginning even before I took over. It seems we need to study what happens if we avoid this tag

@isidorn
Copy link
Contributor

isidorn commented Jan 19, 2022

Let's reopen.

@isidorn isidorn reopened this Jan 19, 2022
@isidorn isidorn removed the info-needed Issue requires more information from poster label Jan 19, 2022
@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2022

No action items I see from this item thus closing.
We can reopen in the future if we figure out what to do here

@isidorn isidorn closed this as completed Mar 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension-recommendations Extension recommendations issues extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

4 participants
@digitarald @isidorn @sandy081 and others