Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new cell execution UI hints #141223

Closed
3 tasks done
roblourens opened this issue Jan 22, 2022 · 2 comments
Closed
3 tasks done

Test new cell execution UI hints #141223

roblourens opened this issue Jan 22, 2022 · 2 comments

Comments

@roblourens
Copy link
Member

roblourens commented Jan 22, 2022

Refs: #130611

Complexity: 3

Create Issue


This feature was 3 changes:

  • When no executing cell is scrolled into view, the editor-level progress bar will be visible
  • A "Go To Executing Cell" button has been added to the notebook toolbar, when the cell is executing
  • When a cell is executing, it gets an animated 🔄 icon where it appears in the breadcrumbs and outline (enable notebook.outline.showCodeCells to see this)

  • Test that these all work as expected
  • The editor progress bar is hidden and shown when clicking from the notebook to another editor, back to the notebook, while a cell is still executing
  • The animations never get stuck showing when a cell is not actually executing
  • For 🌟 bonus points 🌟 , test this with Jupyter debugging. Setup steps here. The animations should not animate when a cell is paused in the debugger.
@JacksonKearl
Copy link
Contributor

Works well! Noticed some weird things with multiple cells running at once, I didn't realize Jupyter doesn't actually support that. But it'd be nice to have for Handy.

@kimadeline
Copy link

kimadeline commented Jan 25, 2022

Looks good to me! Only noticed a couple of small details, sadly I couldn't get the debugging to work (seems like it's because I'm using the latest ipykernel) 😔

@kimadeline kimadeline removed their assignment Jan 25, 2022
@chrmarti chrmarti removed their assignment Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants