Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: electron 16 update #141268

Closed
3 tasks done
deepak1556 opened this issue Jan 24, 2022 · 1 comment
Closed
3 tasks done

Test: electron 16 update #141268

deepak1556 opened this issue Jan 24, 2022 · 1 comment

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Jan 24, 2022

Refs: #137241

Complexity: 4

Create Issue


We plan to promote Electron 16 in the February 2022 milestone for insiders and stable. This adoption also comes with new render process architecture and it would help to get additional exploratory self-hosting. The following tests cover some of the common UI bits that don't have smoke tests, but feel free to self-host on the nightly builds for rest of the iteration. You can download the nightly explorations builds from here for testing.


Testing:

  • macOS:

    • Enable Native Tabs (via settings: window.nativeTabs: true)
      • Launch application
      • Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
      • Verify new window is launched as a new tab in the active instance of the application
    • window is focused when starting from command line
      • open the code exploration application from finder or dock
      • open external terminal
      • run code-exploration
      • make sure the new window is put to foreground
  • windows:

    • touch device, verify onscreen keyboard doesn't pop up when clicking inside vscode while external keyboard is attached
    • verify maximize and restore operations work as expected when task bar is auto-hidden for custom titlebar
    • Verify titlebar is not clipped off when exit fullscreen
      • Maximize VS Code window
      • Press F11 or Ctrl+K Z twice to enter/exit full screen.
      • Verify titlebar is not cropped
    • Verify there is no rendering lag with custom titlebar
  • linux:

  • All OS:

    • Ensure reload operation does not break application features. In this version, we have a change in architecture were workbench process will be reused across reloads instead of launching a new process.
      • In an active window instance of the application perform a reload either via Developer: Reload Window command or switch workspace in a window
      • Ensure the following works
        • Search from UI
        • Extension UI
        • Syntax highlighting
        • Searching a file via quick pick
      • Try to perform reload in many other scenarios as well and see if any of the above UI break.
    • Check out the electron-16.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using Developer: Toggle Developer Tools
@deepak1556 deepak1556 added this to the January 2022 milestone Jan 24, 2022
@ghost ghost assigned weinand, amunger and lramos15 Jan 25, 2022
@amunger amunger removed their assignment Jan 25, 2022
@lramos15 lramos15 removed their assignment Jan 26, 2022
@weinand
Copy link
Contributor

weinand commented Jan 26, 2022

@deepak1556 Since I was running into this again...

In order to make native macOS tabs work in VS Code it is necessary to enable native tabs in macOS > Preferences > General > Prefer tabs: "always":

CleanShot 2022-01-26 at 17 05 28@2x

@weinand weinand removed their assignment Jan 26, 2022
@weinand weinand closed this as completed Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants