-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow debug adapters to customize the behavior of the 'restart' button #14189
Comments
@roblourens yes, that makes a lot of sense (and we were discussing this use case already when implementing the current 'restart' functionality). |
I've added a @isidorn please adopt this by calling the restart request if supportsRestartRequest is true (and skip the default implementation that terminates the adapter and launches it anew). |
@roblourens please adopt this feature in the Debugger for Chrome. |
Verified by using Chrome debug extension for VS Code. Restarting refreshes VS Code |
I am not sure if above comment is the right way of verification, hence removing the verified tag. If you can let me know the right way I can verify it. |
@roblourens did you surface this new feature in the 'Debugger for Chrome'? |
Yes, that's correct @sandy081 |
For the chrome debugging extension, it would be much more useful if the debug 'restart' button/action could refresh the page. This could be implemented by the debug adapter. For other cases, the current behavior should be kept where vscode shuts down/restarts the debug adapter. Is this generic enough to be part of the debug protocol?
The text was updated successfully, but these errors were encountered: