Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Editor Mouse Pointer - Again #142208

Open
dmaixner93 opened this issue Feb 4, 2022 · 3 comments
Open

Dark Editor Mouse Pointer - Again #142208

dmaixner93 opened this issue Feb 4, 2022 · 3 comments
Assignees
Labels
editor-rendering Editor rendering issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@dmaixner93
Copy link

dmaixner93 commented Feb 4, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.64.0
  • OS Version: macOS Catalina 10.15.7 & Monterey 12.1 (Checked two different systems)

Steps to Reproduce:

  1. Open VSCode
  2. Select a dark theme
  3. Observe text cursor

I opened an issue back in May 2020 in regards to this "issue". This may also fit as a "feature request", as I am aware that this also may be more of a personal preference.

Before updating to 1.64.0 the mouse pointer appearance "inverted". (This screenshot is from X Code, but I can confirm that this was the style in VSCode before updating to 1.64.0)
Screen Shot 2022-02-04 at 8 51 27 AM

After updating to 1.64.0 the cursor appears like with a black center and a white outline making it "thicker".
Screen Shot 2022-02-04 at 8 48 57 AM

As mentioned above, this might be more of a personal preference. I like to use the text cursor for assistance when scanning code (as I imagine a lot of fellow coders do) and I find that the "light mode" cursor blocks text. But I can also understand the preference for the "thicker"/light mode cursor on a dark surface.

Would this be a possible setting to add to the settings? I believe it would also help avoid future "issues" regarding the mouse pointer.

Thanks for all your help and time.

@alexdima
Copy link
Member

alexdima commented Feb 4, 2022

Here's some background:

  • since quite some time, on macOS, we have been using a custom text cursor (I) because the text cursor would render black-on-black and would not be visible when using vscode with a dark theme
  • since macOS Catalina the native cursor has a white border which makes it work well also on dark themes, making our custom cursor not necessary
  • macOS High Sierra is no longer supported by Apple (since autumn 2021), so we can assume we don't need to support it anymore
  • the custom cursor we have been shipping would override custom system cursor settings, which are sometimes used to make the cursor more visible, like for high-contrast. see Accessibility: Dark Themes override text selection mouse cursor #140490

Have you tried tweaking Accessibility > Display > Pointer to find something that might work better for you?

@alexdima alexdima added editor-rendering Editor rendering issues and removed triage-needed labels Feb 4, 2022
@dmaixner93
Copy link
Author

Very interesting. Everything you mentioned makes a lot more sense. In the early days of dark themes, the text pointer appeared to be an over sight.

If we are stuck to the system-provided cursor, then, so be it. Sometimes just knowing the story behind the item is enough.

Unfortunately with macOS, there is not much tweaking. Can only make the cursor larger, which really just hides even more.

@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 24, 2022
@saiballo
Copy link

same problem on ubuntu 22.04 and dark theme.

I selected dmz-white pointer but on panels of vscode the pointer is black

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-rendering Editor rendering issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants
@saiballo @alexdima @dmaixner93 and others