Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test finalized icon contribution API #143637

Closed
1 task done
aeschli opened this issue Feb 22, 2022 · 2 comments
Closed
1 task done

Test finalized icon contribution API #143637

aeschli opened this issue Feb 22, 2022 · 2 comments

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 22, 2022

Refs: #119101

Complexity: 3

Create Issue


To verify:

	"icons": {
		"foo-climate": {
			"description": "Climate icon",
			"default": {
				"fontPath": "./seti.woff",
				"fontCharacter": "\\E014"
			}
		},
		"foo-search-light": {
			"description": "Search light icon",
			"default": {
				"fontPath": "./seti.woff",
				"fontCharacter": "\\E015"
			}
		}
	}
  • create a status bar entry and use $(foo-climate)
		const item = vscode.window.createStatusBarItem();
		item.text = 'Hello $(foo-climate) $(foo-search-light) $(zap)';

Test that the icons show
Test that no enabledApiProposals is needed.

@aeschli aeschli added this to the February 2022 milestone Feb 22, 2022
@ghost ghost assigned Tyriar Feb 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

@aeschli probably not an issue but fyi:

image

@Tyriar Tyriar closed this as completed Feb 23, 2022
@Tyriar Tyriar removed their assignment Feb 23, 2022
@aeschli
Copy link
Contributor Author

aeschli commented Feb 24, 2022

I corrected the sample, underscore is not allowed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants