Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt ErrorNoTelemetry on expected errors #145043

Closed
lramos15 opened this issue Mar 14, 2022 · 1 comment
Closed

Adopt ErrorNoTelemetry on expected errors #145043

lramos15 opened this issue Mar 14, 2022 · 1 comment
Assignees
@lramos15 @sbatten
Labels
engineering VS Code - Build / issue tracking / etc. error-telemetry VS Code - Issues generated by telemetry
Milestone
On Deck

Comments

@lramos15
Copy link
Member

Currently we have a lot of errors which are expected to occur and are being thrown on purpose but end up polluting our telemetry pipeline. The newly added ErrorNoTelemetry class acts as a normal Error but instead does not get sent through telemetry and therefore does not pollute the error health site. Further adoption of this class will continue increasing the usefulness of the error site by allowing more of the errors to be actionable on our part.
@lramos15 lramos15 added error-telemetry VS Code - Issues generated by telemetry engineering VS Code - Build / issue tracking / etc. labels Mar 14, 2022
@lramos15 lramos15 added this to the March 2022 milestone Mar 14, 2022
@kieferrm kieferrm mentioned this issue Mar 14, 2022
Closed
87 tasks
@lramos15 lramos15 modified the milestones: March 2022, April 2022 Mar 21, 2022
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@lramos15 lramos15 modified the milestones: April 2022, May 2022 Apr 26, 2022
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@lramos15 lramos15 modified the milestones: May 2022, On Deck May 27, 2022
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
99 tasks
@kieferrm kieferrm mentioned this issue Jul 9, 2022
Closed
98 tasks
@lramos15
Copy link
Member Author

lramos15 commented Dec 9, 2022

Closing as I believe these have been adopted in all the necessary places.

@lramos15 lramos15 closed this as completed Dec 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

@sbatten sbatten

Labels
engineering VS Code - Build / issue tracking / etc. error-telemetry VS Code - Issues generated by telemetry
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@lramos15 @sbatten