Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language status item shows duplicate spinning icons when busy #145115

Closed
CsCherrYY opened this issue Mar 15, 2022 · 2 comments
Closed

Language status item shows duplicate spinning icons when busy #145115

CsCherrYY opened this issue Mar 15, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-status Status bar
Milestone

Comments

@CsCherrYY
Copy link
Contributor

Does this issue occur when all extensions are disabled?: No

Version: 1.65.2 (user setup)
Commit: c722ca6
Date: 2022-03-10T14:33:55.248Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Currently if we pin an item and we mark it busy, the spinning icon will appear in both language status item (the left one) and pinned item (the right one).

Screenshot 2022-03-15 163021

IMO it's a little duplicated and it would be great to show the busy icon only in the language status item (the left one) to help users focus on the item.

@jrieken jrieken assigned jrieken and unassigned joyceerhl Mar 15, 2022
@jrieken jrieken added this to the March 2022 milestone Mar 15, 2022
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug workbench-status Status bar labels Mar 15, 2022
@jrieken
Copy link
Member

jrieken commented Mar 16, 2022

Pushed a fix that ensures that one item isn't causing two spinners. However, when a pinned and unpinned item mark themselves as busy you can still see two spinners.

@CsCherrYY
Copy link
Contributor Author

@jrieken just tested in the insiders version, works great, thanks!

image

@jrieken jrieken added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-status Status bar
Projects
None yet
Development

No branches or pull requests

4 participants
@jrieken @joyceerhl @CsCherrYY and others