Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] high contrast theme not switched to regular theme on startup #145698

Closed
hediet opened this issue Mar 22, 2022 · 3 comments
Closed

[themes] high contrast theme not switched to regular theme on startup #145698

hediet opened this issue Mar 22, 2022 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone

Comments

@hediet
Copy link
Member

hediet commented Mar 22, 2022

Testing #145616

Steps:

  1. Set a color theme in VS Code (no high contrast) -> Works
  2. Enable high contrast theme in OS (Windows) -> VS Code switches to high contrast theme
  3. Restart VS Code -> VS Code stays in high contrast theme
  4. Disable high contrast theme in OS -> VS Code stays in high contrast theme!

For step 4, I would have expected that VS Code would go back to the normal color theme.
When leaving out step 3, it does so.

@aeschli
Copy link
Contributor

aeschli commented Mar 23, 2022

Yes, I know it's inconsistent, but it's something we do on purpose: Never switch away from a high contrast theme on restart. IMO it's time to remove that. @bpasero any objections?

@aeschli aeschli added the themes Color theme issues label Mar 23, 2022
@aeschli aeschli changed the title Original Color Theme Is Overwritten When Restarting VS Code [themes] high contrast theme not switched to regular theme on startup Mar 23, 2022
@aeschli aeschli added the feature-request Request for new features or functionality label Mar 23, 2022
@bpasero
Copy link
Member

bpasero commented Mar 23, 2022

No, feel free to change.

@aeschli aeschli added this to the April 2022 milestone Mar 23, 2022
@aeschli aeschli modified the milestones: April 2022, May 2022 Apr 25, 2022
@aeschli aeschli modified the milestones: May 2022, Backlog May 30, 2022
@aeschli
Copy link
Contributor

aeschli commented Jul 15, 2022

This has been fixed in the meantime

@aeschli aeschli closed this as completed Jul 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants