Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline suggestions aren't multicursor aware #146041

Closed
jrieken opened this issue Mar 25, 2022 · 8 comments
Closed

Inline suggestions aren't multicursor aware #146041

jrieken opened this issue Mar 25, 2022 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality inline-completions papercut 🩸 A particularly annoying issue impacting someone on the team verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2022

  • enable inline suggest via editor.quickSuggestions and inline
  • have multiple cursors and type con
  • accept the inline completion
  • only the primary cursor is completed
@emanuelescarabattoli
Copy link

I confirm this behavior, as you can see from the following screenshots.

Before to hit tab:

Screenshot 2022-05-06 at 12 01 52

After hitting tab:

Screenshot 2022-05-06 at 12 01 58

Expected behavior:

Screenshot 2022-05-06 at 12 02 11

@riskoviv
Copy link

The workaround I use for now is press Ctrl + Space and select suggested variant by Tab/Enter, but selecting it just by Tab would be a lot better of course.

@Semesse
Copy link
Contributor

Semesse commented Aug 9, 2022

Hello, team~ I'd like to fix this issue, but I'm not sure if there's any case the completion item would be so complicated that we need to calculate how many characters we should overwrite before each cursor. Or I guess we can insert ghost text for any existing cursor as an intuitive fix?

@hediet
Copy link
Member

hediet commented Aug 11, 2022

@Semesse unfortunately the code is not very straight forward.

@jrieken jrieken added the papercut 🩸 A particularly annoying issue impacting someone on the team label Oct 28, 2022
@Entwaze

This comment was marked as abuse.

@Tomaqa
Copy link

Tomaqa commented Nov 16, 2023

I guess that showing the ghost text only at the first cursor as it is now (i.e. not at all cursors) is not ideal but quite OK, while the priority is accepting the suggestion at all cursors?

@riskoviv
Copy link

@Tomaqa, yes, you're right. Showing the ghost text is not so important, main issue is lack of inserting of suggested text to positions of all cursors.

@hediet
Copy link
Member

hediet commented Jul 9, 2024

We have this for a while now 🥳 #205562

@hediet hediet closed this as completed Jul 9, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality inline-completions papercut 🩸 A particularly annoying issue impacting someone on the team verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants