Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when default profile is not set on mac, login args aren't provided #148451

Closed
meganrogge opened this issue Apr 29, 2022 · 2 comments · Fixed by #148671
Closed

when default profile is not set on mac, login args aren't provided #148451

meganrogge opened this issue Apr 29, 2022 · 2 comments · Fixed by #148671
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-profiles terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
May 2022

Comments

@meganrogge
Copy link
Contributor

reported by @JacksonKearl #145824
@meganrogge meganrogge self-assigned this Apr 29, 2022
@meganrogge meganrogge added this to the May 2022 milestone Apr 29, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-profiles labels Apr 29, 2022
@meganrogge
Copy link
Contributor Author

config becomes undefined here

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Line 940 in d982c14

const config = options?.config || this._terminalProfileService.availableProfiles?.find(p => p.profileName === this._terminalProfileService.getDefaultProfileName());

@meganrogge meganrogge mentioned this issue May 3, 2022
Merged
@meganrogge meganrogge added the terminal-shell-integration Shell integration infrastructure, command decorations, etc. label May 3, 2022
@meganrogge meganrogge mentioned this issue May 3, 2022
Merged
@meganrogge meganrogge mentioned this issue May 5, 2022
Closed
@meganrogge
Copy link
Contributor Author

to verify:

  • set your default profile to null
  • add something to your .zprofile such as an echo statement
  • create a zsh terminal
  • ensure your .zprofile file has been run

@kimadeline kimadeline added the verified Verification succeeded label Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-profiles terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

when defaultProfile is undefined, set all profile props on SLC microsoft/vscode
4 participants
@Tyriar @meganrogge @kimadeline and others