Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: up arrow go to bottom of quick fix ⌘. menu #148566

Closed
MarkPieszak opened this issue May 2, 2022 · 2 comments
Closed

feature request: up arrow go to bottom of quick fix ⌘. menu #148566

MarkPieszak opened this issue May 2, 2022 · 2 comments
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@MarkPieszak
Copy link

MarkPieszak commented May 2, 2022

Currently, when opening the Quick Fix menu via ⌘.:

Current Behavior:

It automatically has the first item at the top of the menu selected, and you are unable to push Up Arrow to get to the bottom of the list.

This would be extremely helpful in situations like eslint/prettier when the "fix with prettier" (or similar option) is always at the bottom of the list.

image

Desired Behavior:

To push the up arrow on the Quick Fix menu, and it takes you to the bottom of the list.


This desired behavior actually already exists when doing a right click somewhere (as nothing is selected), and you are able to push Up Arrrow, and it takes you to the bottom of the list.

Fantastic work on VSCode as always, this is a super minor thing - but I think it would be fantastic for an even better DX <3

@mjbvz mjbvz added the editor-code-actions Editor inplace actions (Ctrl + .) label Aug 4, 2022
@justschen
Copy link
Contributor

@MarkPieszak I think this should be resolved (in both the original Quick Fix Menu and with the new Code Action Widget which will replace this menu - see #152913)

Just one thing though - @mjbvz can you confirm some behavior on MacOS vs Windows?

When hitting Ctrl + . on Windows, the Quick Fix menu will actually include the Learn more about TS/JS Refactoring option. When opening the Quick Fix menu from an error (View Problem) and hitting the text that says Quick Fix..., the menu won't include the Learn more.... option.

Is this the same with ⌘ + . on Mac? This means that hitting the up arrow works, but would be an option that most users wouldn't intend to click on.

@mjbvz mjbvz added this to the August 2022 milestone Aug 4, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 5, 2022

@justschen Yes that's the same behavior on macOS too

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Aug 23, 2022
@lszomoru lszomoru added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants