Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eol #148984

Closed
sujingang opened this issue May 7, 2022 · 4 comments
Closed

eol #148984

sujingang opened this issue May 7, 2022 · 4 comments
Assignees
Labels
formatting Source formatter issues

Comments

@sujingang
Copy link

Issue Type: Feature Request

The code I pulled from the git repository has both LF and CRLF line breaks. When I use vscode to save, vscode automatically unifies all line breaks as LF or CRLF, but I use source insight. Shouldn't I just change the lines I modified when I'm thinking the editor saves the file? Why modify the entire file?

VS Code version: Code 1.67.0 (57fd6d0, 2022-05-04T12:06:02.889Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

@sujingang
Copy link
Author

I don't want to change the newlines for non-modified lines

@lszomoru
Copy link
Member

@sujingang, could you try using the editor.formatOnSaveMode setting?

@lszomoru lszomoru added the formatting Source formatter issues label Jul 11, 2022
@qinhanlei
Copy link

The same issue,editor.formatOnSaveMode is false, and I've tried disable all other extensions.
When I saved the mixed EOL file, It changed to the non-mixed EOL file.
We want to keep it mixed for a while for some historical reasons.

@alexdima
Copy link
Member

alexdima commented Dec 6, 2022

Let's track in #127

@alexdima alexdima closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
formatting Source formatter issues
Projects
None yet
Development

No branches or pull requests

4 participants