Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme] Monokai theme: parameters are not colored in Orange #1504

Closed
egamma opened this issue Dec 20, 2015 · 4 comments
Closed

[theme] Monokai theme: parameters are not colored in Orange #1504

egamma opened this issue Dec 20, 2015 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Dec 20, 2015

Extracted from issue #1470.

I am using Monokai, where function parameters are displayed in orange, but with this update the parameters are displayed in gray although the Monokai.tmTheme clearly states that parameters should be orange (#FD971F).

@egamma egamma added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues labels Dec 20, 2015
@egamma egamma added this to the Backlog milestone Dec 20, 2015
@egamma
Copy link
Member Author

egamma commented Dec 20, 2015

The same problem occurs in TS.

@aeschli aeschli changed the title Monokai theme: parameters are not colored in Orange [theme] Monokai theme: parameters are not colored in Orange Jan 13, 2016
@aeschli aeschli modified the milestones: Jan 2016, Backlog Jan 13, 2016
@lcrespom
Copy link

I just installed version 0.10.6, commit a80232b, and parameters are still gray.
Does commit a80232b contain this fix?

I opened tokens.css in C:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\languages\markdown\common and searched for ".token.meta.parameter", and it's not there, so it seems the fix is in this commit, but the monokai theme is still broken.

@aeschli
Copy link
Contributor

aeschli commented Jan 19, 2016

@lcrespom 0.10.6 is the December release. You will see this in the January release due January 29.
See #1826

@lcrespom
Copy link

Thank you, I eagerly wait for that release :-)

@aeschli aeschli assigned isidorn and unassigned aeschli Jan 28, 2016
@isidorn isidorn added the verified Verification succeeded label Jan 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants