Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git editor can't find script #150463

Closed
ArturoDent opened this issue May 26, 2022 · 6 comments
Closed

git editor can't find script #150463

ArturoDent opened this issue May 26, 2022 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@ArturoDent
Copy link

ArturoDent commented May 26, 2022

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. Enable both Git: Use Editor as Commit Input and Git: Verbose Commit
  2. Stage some changes for a commit.
  3. With an empty commit message input, trigger either Ctrl</kbd?+Enter (with focus in message input) or Git: Commit from Command Palette`.
  4. The following error message pops up:
    gitEditorErrorMessage

Where it is looking:

c:\Users\Mark\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\scripts\git-editor.bat

[2022-05-26T15:56:24.640Z] 'c:\Users\Mark\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\scripts\git-editor.bat': c:\Users\Mark\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\scripts\git-editor.bat: No such file or directory
error: There was a problem with the editor ''c:\Users\Mark\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\scripts\git-editor.bat''.
Please supply the message using either -m or -F option.
[2022-05-26T15:56:24.733Z] > git config --get-all user.name [83ms]
[2022-05-26T15:56:24.816Z] > git config --get-all user.email [77ms]

Where it is actually located on my machine:

C:\Users\Mark\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\gitEditor\scripts\git-editor.bat

Is the builtin git extension slower to update than Insiders?

Version: 1.68.0-insider (user setup)
Commit: 528ee1a
Date: 2022-05-26T05:16:43.433Z
Electron: 17.4.4
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.25120

@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@ArturoDent
Copy link
Author

It looks like the TriageBot has an issue too - since I am using the Insiders Build and not Stable - it shouldn't be producing that flag about Stable.

@albireox
Copy link

I can confirm that this also happens in macOS. If I move or symlink the file to the location where the error message says it's looking for git-editor.sh I get

[2022-05-26T15:51:35.065Z] error: There was a problem with the editor ''/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/git/dist/scripts/git-editor.sh''.
Please supply the message using either -m or -F option.

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority git GIT issues labels May 26, 2022
@lszomoru lszomoru added this to the May 2022 milestone May 26, 2022
@lszomoru
Copy link
Member

I am reverting the commit that introduced this feature until we iron out these issues. Apologies for the inconvenience.

@lszomoru
Copy link
Member

I am closing this issue for now as the change that caused this has been reverted.

@joyceerhl joyceerhl added the verified Verification succeeded label Jun 2, 2022
@joyceerhl
Copy link
Contributor

Marking as verified since it's not currently possible to enable Git: Use Editor as Commit Input

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants