Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how to run cells if in serverless untrusted workspace and trying to connect to remote server #151156

Closed
joyceerhl opened this issue Jun 2, 2022 · 4 comments
Assignees
Labels
notebook-remote under-discussion Issue is under discussion for relevance, priority, approach

Comments

@joyceerhl
Copy link
Collaborator

Testing microsoft/vscode-jupyter#10183

In restricted mode, I don't see the command to specify a Jupyter server, and if I click the run button I get this message (which maybe RemoteHub shouldn't contribute anymore? cc @roblourens)

Wondering if we want to show the command in the palette in restricted mode, but request workspace trust when it's invoked. Not sure if this has been discussed before so please forgive me if I'm rehashing an existing discussion.

image

@rebornix rebornix assigned roblourens and rchiodo and unassigned rebornix Jun 2, 2022
@greazer greazer added bug Issue identified by VS Code Team member as probable bug notebook-remote iteration-candidate and removed triage-needed labels Jun 2, 2022
@greazer greazer transferred this issue from microsoft/vscode-jupyter Jun 2, 2022
@greazer
Copy link
Member

greazer commented Jun 2, 2022

Need to have better control over what message is displayed when viewing a notebook using vscode.dev. Users can use pyodide, or connect to remote jupyter servers, in addition to codespaces.

@joyceerhl
Copy link
Collaborator Author

@greazer to clarify, the main pain point I have here is that the command to specify a Jupyter server shouldn't be hidden in an untrusted workspace if that is the entrypoint that users are looking for. In the same vein, the debug view is not hidden in an untrusted workspace, but if you attempt to launch + debug in restricted mode you get this dialog
image

@joyceerhl joyceerhl changed the title Unclear how to run cells if in untrusted workspace Unclear how to run cells if in serverless untrusted workspace and trying to connect to remote server Jun 2, 2022
@roblourens
Copy link
Member

Not sure how this experience is expected to work - why can't I connect to the remote in an untrusted workspace, then when I try to run a cell, I will be prompted to trust the workspace, like usual?

Besides that, currently there are no kernels contributed in web, whether or not the workspace is trusted, and the "Select kernel" button is hidden. Why do we hide it, is that something we hardcoded for web? @rebornix

In the future, I think I will also see the "Github" or other option for lazy kernel appear. If there is something in that list, then the normal behavior for the run button will kick in - you click it and trigger vscode core's run command which asks you to trust the workspace, then pick a kernel.

But if lazy kernels aren't available, we probably want to still push them towards codespaces with "continue on"

@roblourens roblourens added under-discussion Issue is under discussion for relevance, priority, approach and removed bug Issue identified by VS Code Team member as probable bug labels Jun 7, 2022
@roblourens
Copy link
Member

why can't I connect to the remote in an untrusted workspace, then when I try to run a cell, I will be prompted to trust the workspace, like usual?

That is how it works now

@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-remote under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

5 participants