-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook saving doesn't trim code cell whitespace when files.trimTrailingWhitespace setting is true #151982
Comments
VS code handles file serialization but not sure if 'file.TrimTrailingWhiteSpace' would apply to individual cells? Maybe a new setting? |
I don't think a new setting is needed for this scenario. If you look at the screenshot, from the user point of view it seems to me that the highlighted trailing spaces should be removed when the notebook is saved if I'm not sure why notebooks should ignore that setting, even if the saving mechanics are more complicated. The notebook respects most other settings and it's one of the stated goals to make the notebook experience as similar to regular editing. |
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
Applies To
What happened?
When I save a Jupyter notebook which has trailing whitespace in it's code cells, I expect it to be trimmed if
files.trimTrailingWhitespace
istrue
VS Code Version
Version: 1.68.0 (user setup) Commit: 4af164e Date: 2022-06-08T11:44:16.822Z Electron: 17.4.7 Chromium: 98.0.4758.141 Node.js: 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0.19044
Jupyter Extension Version
v2022.5.1001601848
Jupyter logs
No response
Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
No response
The text was updated successfully, but these errors were encountered: