Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility]: Terminal output is not read in real time on Mac for VoiceOver #154027

Closed
jooyoungseo opened this issue Jul 3, 2022 · 12 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member verified Verification succeeded
Milestone

Comments

@jooyoungseo
Copy link

CC @isidorn

I have tried VSCode terminal on Mac with accessibility setting being turned on.
Currently, terminal live region output
is not read by VoiceOver in realtime.
I have tested this with the latest VSCode released version as well as the latest insider version.

@isidorn
Copy link
Contributor

isidorn commented Jul 28, 2022

@jooyoungseo thanks for filling this issue, and sorry for the slow response I was on vacation.

For me the content of the terminal nicely gets read out on my mac.
Do you have exact reproducable steps for this? Can you still reproduce this with latest insiders?

Assigning to @Tyriar and @meganrogge for terminal.

@isidorn isidorn assigned Tyriar and meganrogge and unassigned isidorn Jul 28, 2022
@isidorn isidorn added info-needed Issue requires more information from poster accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jul 28, 2022
@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@Tyriar Tyriar added macos Issues with VS Code on MAC/OS X confirmation-pending and removed info-needed Issue requires more information from poster labels Aug 5, 2022
@Tyriar Tyriar added this to the Backlog milestone Aug 5, 2022
@Tyriar Tyriar reopened this Aug 5, 2022
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2022
@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2022

Related: #144928

@meganrogge meganrogge added confirmed Issue has been confirmed by VS Code Team member and removed confirmation-pending labels Dec 13, 2022
@meganrogge
Copy link
Contributor

document.activeElement.parentElement.classList.contains('xterm-accessibility-tree') is false here when it should be true

Screenshot 2022-12-12 at 7 31 39 PM

@meganrogge
Copy link
Contributor

meganrogge commented Dec 13, 2022

sometimes it does work though 🤔

screen.mov

@meganrogge meganrogge removed the macos Issues with VS Code on MAC/OS X label Dec 13, 2022
@meganrogge
Copy link
Contributor

On Windows, it reads "list item 12 of 13" etc. instead of the text content

@meganrogge
Copy link
Contributor

@jooyoungseo does this always reproduce for you? It happens intermittently for me.

@Tyriar
Copy link
Member

Tyriar commented Dec 15, 2022

Upstream issue: xtermjs/xterm.js#3247

@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2023

Prototype for new view that could replace navigation mode all together: xtermjs/xterm.js#4340

@meganrogge
Copy link
Contributor

will be fixed with #169853

@jooyoungseo
Copy link
Author

I believe the new prototype using contenteditable will be a game changer! Blind programmers used to rely on an external terminal due to inconvenient integrated terminal navigation. Looking forward to it!

@Tyriar
Copy link
Member

Tyriar commented Jan 10, 2023

@jooyoungseo great to hear that, let us know when it ends up shipping 🙂

@connor4312 connor4312 added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants