Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder text should be diff't when there are no kernels #154185

Closed
meganrogge opened this issue Jun 28, 2022 · 6 comments
Closed

placeholder text should be diff't when there are no kernels #154185

meganrogge opened this issue Jun 28, 2022 · 6 comments
Assignees
Labels
debt Code quality issues notebook-kernel

Comments

@meganrogge
Copy link
Contributor

Testing microsoft/vscode-jupyter#10590
Screen Shot 2022-06-28 at 1 32 12 PM

@meganrogge
Copy link
Contributor Author

better yet, should clicking the install python extension button just run that action instead of showing the quickpick?

@IanMatthewHuff
Copy link
Member

better yet, should clicking the install python extension button just run that action instead of showing the quickpick?

With the current API we don't have that option. But I know that @greazer was keen on the same suggestion. Maybe we can tweak the core kernel selector code to just perform the action if the one and only thing in the list is a kernel command as opposed to an actual kernel.

@IanMatthewHuff
Copy link
Member

@rebornix Assigning to you so it doesn't get lost in the transfer, but I could actually help with this if we think there is some work to do here. I always like the chance to make core changes to get into the code base more.

@IanMatthewHuff IanMatthewHuff transferred this issue from microsoft/vscode-jupyter Jul 5, 2022
@rebornix
Copy link
Member

rebornix commented Jul 5, 2022

@IanMatthewHuff not sure if we have code changes there recently but running the only available command by default should be the behavior IMHO. Do you have steps of how to get into this state?

@IanMatthewHuff
Copy link
Member

@rebornix I think the ask here is a bit different (the run command does work as you describe).

The ask here is around the following:

  1. One and only one command in the list
  2. Click the command (not the run button)

The thought here is either:

  1. If there is only one command in the selector don't pop up the selector when you click it. Just run the command, picking the selector is just a second step when there is only one option here.
  2. The placeholder text isn't really correct here. It doesn't indicate that there is only a command here. Either the placeholder text could change or I could better tweak the command name to indicate what is happening.

FWIW I'm not 100% sure if we should change this. It's a bit funny for that Button to change function from a selector to instead just running the command as there isn't a UI affordance to see when you only have one command there. But worth considering at least.

@rebornix
Copy link
Member

Closing it for now as we are making changes to the kernel picker with MRU exploration.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues notebook-kernel
Projects
None yet
Development

No branches or pull requests

5 participants