Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized keybindings mismatched #1549

Closed
marinabilles opened this issue Dec 21, 2015 · 2 comments
Closed

Localized keybindings mismatched #1549

marinabilles opened this issue Dec 21, 2015 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@marinabilles
Copy link

The "navigateBack" command is listed in my config file as:

{ "key": "ctrl+alt+-",            "command": "workbench.action.navigateBack" }

I am using the German keyboard layout with Visual Studio Code. I get a tooltip over "ctrl+alt+-" telling me to press "ctrl+alt+ß" instead (the ß key of the German keyboard is at the position of the - key on the English keyboard)

However, the command I actually have to press in order to navigate backwards is ctrl+alt+-, using the - key of the German keyboard, which is somewhere else entirely.

Thus, the tooltip is incorrect while the key as it is stated in the config file is correct.

Edit: my operating system is Linux x64 (Ubuntu 14.04)

@egamma egamma added the bug Issue identified by VS Code Team member as probable bug label Dec 21, 2015
@egamma egamma added this to the Backlog milestone Dec 21, 2015
@egamma egamma added the editor label Dec 21, 2015
@alexdima alexdima modified the milestones: Jan 2016, Backlog Jan 26, 2016
@alexdima
Copy link
Member

I can reproduce the problem, but it needs an investigation inside node-native-keymap

@alexdima alexdima modified the milestones: Feb 2016, Jan 2016 Jan 29, 2016
@alexdima alexdima modified the milestones: Backlog, Feb 2016 Feb 25, 2016
@alexdima alexdima added linux Issues with VS Code on Linux keyboard-layout Keyboard layout issues labels Mar 24, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in today's Insiders build) appear to behave correctly for this keybinding under the German keyboard layout on Ubuntu:

image

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 24, 2017
@chrmarti chrmarti added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants