Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround in launch config arg escaping #155795

Open
roblourens opened this issue Jul 21, 2022 · 1 comment
Open

Remove workaround in launch config arg escaping #155795

roblourens opened this issue Jul 21, 2022 · 1 comment
Assignees
@roblourens
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
Backlog

Comments

@roblourens
Copy link
Member

From #149910

We decided to not escape args that are simply < and >. Once debug adapters have adopted the new approach, we can remove that workaround.

vscode/src/vs/workbench/contrib/debug/node/terminals.ts

Line 116 in eaeb3a7

command += (a === '<' || a === '>' || argsCanBeInterpretedByShell) ? a : quote(a);

@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Jul 21, 2022
@roblourens roblourens added this to the Backlog milestone Jul 21, 2022
@roblourens roblourens self-assigned this Jul 21, 2022
@roblourens roblourens modified the milestones: Backlog, December / January 2024 Dec 15, 2023
@roblourens roblourens modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@roblourens roblourens modified the milestones: February 2024, March 2024 Feb 21, 2024
@roblourens roblourens modified the milestones: March 2024, April 2024 Mar 26, 2024
@roblourens
Copy link
Member Author

microsoft/vscode-cpptools#10654

@roblourens roblourens modified the milestones: April 2024, Backlog Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@roblourens