Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support context menu action contributions for debug viewlet views #15657

Closed
weinand opened this issue Nov 17, 2016 · 14 comments
Closed

Support context menu action contributions for debug viewlet views #15657

weinand opened this issue Nov 17, 2016 · 14 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Nov 17, 2016

Support context menu action contributions for debug viewlet views.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 17, 2016
@weinand weinand added the feature-request Request for new features or functionality label Nov 17, 2016
@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2016

@weinand did you sync with @jrieken on this?

@isidorn
Copy link
Contributor

isidorn commented Nov 29, 2016

fyi @roblourens now we support for extensions to contribute context menu items for debug views. For the moment we only support it for the call stack view but this can easily change

From your extension under package.json you can as before contribute "menus", but we introduced a new context called "debug/callstack/context". Under there you can specify a custom command which you want to be added to the debug callstack context menu.
Once executed the command gets the stackFrame internal uri as an argument from which the extension should be able to identify the stack frame.

Try to connect all the dots and if you have issues I can implement this tomorrow in the mock debugger as a template.

@weinand it would be cool if you implemented restart frame using a similar approach and we get rid of the capability

@roblourens
Copy link
Member

Sure, for blackbox scripts this was going to be for next milestone though right? Since we need to communicate between the extension host and debug adapter.

@weinand
Copy link
Contributor Author

weinand commented Nov 29, 2016

@roblourens yes, we will not ship the skipFiles UI for this milestone. But we can experiment with the necessary implementation details...

@isidorn Yes, if we have a richer debug model available to extensions, and if we can communicate to the debug adapter from an extension, it would be possible to implement "Restart Frame" in an extension.

However, we will not do this for these reasons:

  • we cannot remove existing debug UI because it will cripple existing extensions.
  • if we would move more functionality into the extension (as private features), we would make it harder for other frontends (e.g. VS) to support this functionality.

@cmrigney
Copy link

cmrigney commented Nov 30, 2016

@isidorn I would like to implement an extension that runs alongside the "Native Debug" extension that would allow the user to right click on a variable in the debug view for a context menu with a custom button. In my application, the custom button would be "View Image" for an OpenCV Mat C++ object, so I would need the variable info passed along to the context menu action (and possibly be able to hide the button in case it's not a Mat object) so I can use that to draw in an HTML preview window. Will this be available to extensions?

@weinand
Copy link
Contributor Author

weinand commented Nov 30, 2016

@cmrigney yes, we are planning to support this scenario. But we still have to design the debug object model that needs to be surfaced when passing the selection (e.g. the variable) to the context menu action.

@cmrigney
Copy link

@weinand Great thanks. Any idea if this will be in the next release?

@weinand
Copy link
Contributor Author

weinand commented Nov 30, 2016

@cmrigney not in the November release, but in the following.

@jrieken
Copy link
Member

jrieken commented Dec 1, 2016

@weinand
Copy link
Contributor Author

weinand commented Dec 1, 2016

@jrieken thanks for the doc pointer. We will update as soon as these APIs become official.

@weinand weinand removed their assignment Dec 5, 2016
@weinand
Copy link
Contributor Author

weinand commented Dec 5, 2016

This was exploratory work for November. Will be tested in January milestone.

@weinand weinand modified the milestones: January 2017, November 2016 Dec 5, 2016
@egamma egamma mentioned this issue Dec 20, 2016
56 tasks
@CangHaiQingYue
Copy link

How to configure opencv? Is there have any link?

@cmrigney
Copy link

@CangHaiQingYue I'm no longer working with OpenCV, so I didn't develop any extension for it. Not sure if anyone else did.

@CangHaiQingYue
Copy link

@cmrigney Ok thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants