Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sticky scrolling for JavaScript inside of html #156610

Closed
mjbvz opened this issue Jul 28, 2022 · 3 comments
Closed

No sticky scrolling for JavaScript inside of html #156610

mjbvz opened this issue Jul 28, 2022 · 3 comments
Assignees
@aiday-mar
Labels
editor-sticky-scroll feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 28, 2022

Testing #156175

  1. Enable sticky scrolling
  2. with an html file:
<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
</head>
<body>
    <script>
class Foo {



















    
}
    </script>
</body>
</html>

Bug

When scrolling though the file, Foo does not stick. The same code work in a plain JS file
@aiday-mar aiday-mar added feature-request Request for new features or functionality editor-sticky-scroll labels Jul 29, 2022
@aiday-mar aiday-mar added this to the August 2022 milestone Jul 29, 2022
@aiday-mar
Copy link
Contributor

aiday-mar commented Aug 10, 2022 •
edited
Loading

Thanks for the bug. This should be fixed with PR #157483.

sticky-scroll-js-html

@aiday-mar aiday-mar added the verification-needed Verification of issue is requested label Aug 23, 2022
@aiday-mar
Copy link
Contributor

Test

  • Open an HTML file with JavaScript code inside as in the examples above.
  • Verify that sticky scrolling works as expected inside of the JavaScript code block

@luabud luabud added the verified Verification succeeded label Aug 23, 2022
@luabud
Copy link
Member

luabud commented Aug 23, 2022

Looking good!

StickyScroll156610

@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aiday-mar aiday-mar

Labels
editor-sticky-scroll feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

No branches or pull requests
3 participants
@mjbvz @luabud @aiday-mar