Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript regex syntax coloring bug #15692

Closed
tdenisenko opened this issue Nov 18, 2016 · 5 comments
Closed

Javascript regex syntax coloring bug #15692

tdenisenko opened this issue Nov 18, 2016 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@tdenisenko
Copy link

  • VSCode Version: Code 1.7.1 (02611b4, 2016-11-03T13:53:14.822Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version

Steps to Reproduce:
51f96435343e0f939fa35c64b63f6134

  1. Divider symbol "/" and regex string symbol "/" is somehow conflicting with each other and causes wrong coloring and syntax highlighting errors. But the code is working perfectly, and this issue only happens on Visual Code.
  2. The code is attached below:
    $scope.formatPrice = function(num) { if (num >= 1000000) { return (num / 1000000).toFixed(1).replace(/\.0$/, '') + 'M'; } if (num >= 1000) { return (num / 1000).toFixed(1).replace(/\.0$/, '') + 'K'; } return num; } };
@tdenisenko tdenisenko changed the title Regex syntax coloring bug. Javascript regex syntax coloring bug Nov 18, 2016
@ramya-rao-a
Copy link
Contributor

Closing as duplicate of #15334.
@aeschli Looks like the upstream microsoft/TypeScript-TmLanguage#356 is fixed. Any idea, when can we pull in the grammar?

@aeschli
Copy link
Contributor

aeschli commented Nov 18, 2016

@ramya-rao-a I updated the grammar with b8f51b5

@ramya-rao-a ramya-rao-a added typescript Typescript support issues *duplicate Issue identified as a duplicate of another issue(s) upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 18, 2016
@ramya-rao-a
Copy link
Contributor

@aeschli Will the grammar be part of 1.7.2 ?

@ramya-rao-a
Copy link
Contributor

@aeschli FYI, this has been cherry-picked by @kieferrm for 1.72

@aeschli
Copy link
Contributor

aeschli commented Nov 22, 2016

@ramya-rao-a, @kieferrm Let's hope that goes well. I think we should always selfhost on a updated grammar for a week or so.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants