Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support underline styles and colors in the terminal #156983

Closed
Tyriar opened this issue Aug 3, 2022 · 0 comments · Fixed by #156993
Closed

Support underline styles and colors in the terminal #156983

Tyriar opened this issue Aug 3, 2022 · 0 comments · Fixed by #156993
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
August 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 3, 2022

xterm.js issue: xtermjs/xterm.js#1145
WT issue: microsoft/terminal#7228
Docs here: https://sw.kovidgoyal.net/kitty/underlines/

Currently on Windows these will be ignored by conpty (microsoft/terminal#7228)
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-rendering labels Aug 3, 2022
@Tyriar Tyriar added this to the August 2022 milestone Aug 3, 2022
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Aug 3, 2022
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Aug 3, 2022
@Tyriar Tyriar mentioned this issue Aug 3, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 3, 2022
@kieferrm kieferrm mentioned this issue Aug 7, 2022
Closed
@Tyriar Tyriar mentioned this issue Aug 22, 2022
Closed
2 tasks
@Tyriar Tyriar mentioned this issue Aug 22, 2022
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Upgrade to xterm.js v5 beta microsoft/vscode
3 participants
@Tyriar @meganrogge @vscodenpa