Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show keyboard shortcuts in Code Action Widget #157129

Closed
justschen opened this issue Aug 4, 2022 · 1 comment · Fixed by #160449
Closed

Show keyboard shortcuts in Code Action Widget #157129

justschen opened this issue Aug 4, 2022 · 1 comment · Fixed by #160449
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded

Comments

@justschen
Copy link
Contributor

"Is there a plan to show the keyboard shortcuts as well (similar to the old code action context menu)?

This is helpful when there are different more detailed shortcuts for code actions, for example:

Old:
image

New:
image

The 2 shortcuts are not shown in the new version."

Originally posted by @lgrammel in #152913 (comment)

@justschen justschen added the editor-code-actions Editor inplace actions (Ctrl + .) label Aug 4, 2022
@justschen justschen self-assigned this Aug 4, 2022
@justschen justschen added the feature-request Request for new features or functionality label Aug 4, 2022
@mjbvz mjbvz self-assigned this Aug 30, 2022
@mjbvz mjbvz added this to the September 2022 milestone Sep 9, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 9, 2022
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 9, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 12, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2022

To verify:

  1. Create a keybinding for a specific kind of refactoring:
{
        "key": "ctrl+shift+e",
        "command": "editor.action.refactor",
        "args": {
            "kind": "refactor.extract",
            "preferred": true,
            "apply": "ifSingle"
        }
    },
  1. Open the code action widget so a refactoring of the kind above is visible (refactor.extract for example)
  2. Confirm the keybinding shows in the widget next to extract actions

@amunger amunger added the verified Verification succeeded label Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants