Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore view state for cells from redundant fs file change event #157695

Closed
rebornix opened this issue Aug 9, 2022 · 1 comment
Closed

Restore view state for cells from redundant fs file change event #157695

rebornix opened this issue Aug 9, 2022 · 1 comment
Assignees
Labels
notebook-layout polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@rebornix
Copy link
Member

rebornix commented Aug 9, 2022

Originally posted by in #153708 (comment)

As in the demo/gif in #153708, when we receive a content change event which contains no real model change, we still reset the model and lost all view states, which will trigger a flicker when the editor has horizontal scrollbars.

We should avoid the handling of such "redundant" file change events.

@rebornix rebornix self-assigned this Aug 9, 2022
@rebornix rebornix added notebook-layout polish Cleanup and polish issue labels Aug 9, 2022
@rebornix rebornix added this to the August 2022 milestone Aug 9, 2022
@rebornix rebornix added the verification-needed Verification of issue is requested label Aug 19, 2022
@rebornix
Copy link
Member Author

Verification:

  • Open a notebook file in VS Code
  • Select some text in a cell editor
  • Open terminal, touch file.ipynb to trigger a file change event
  • Make sure the cell editor selection doesn't change

@rzhao271 rzhao271 added the verified Verification succeeded label Aug 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-layout polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants