Calling a task using TaskDefinition data does not work in 1.70.0

[ivankravets]

Does this issue occur when all extensions are disabled?: Yes/No

• VS Code Version: 1.70.0
• OS Version: Darwin x64 21.6.0

Steps to Reproduce:

1. Provide a task to the vscode.tasks.registerTaskProvider wit the following data:

    const vscodeTask = new vscode.Task(
      {
        type: "Foo",
        task: "foo.clean-project",
      },
       projectDir,
      "Clean project",
      "Foo",
      ....
    );
 ...

2. Run the task:

This code works:

    vscode.commands.executeCommand('workbench.action.tasks.runTask', {
      type: "Foo",
      task: "Clean project",
    });

whereas, this does not:

    vscode.commands.executeCommand('workbench.action.tasks.runTask', {
      type: "Foo",
      task: "foo.clean-project",
    });

[ivankravets]

Hi @meganrogge and @alexr00,

Could it be a regression of #155635 ?

[ivankravets]

I forgot to mentioned, that we tried to follow VSCode API which has the next:

The task's name. Is presented in the user interface.

So, we show a human-readable task name/description, where call a task later using its ID. You can check the original issue which was reported at platformio/platformio-core#4386 by @DigiH

[meganrogge]

@ivankravets this is how task is currently described and supported - as you state above, providing the label and type will work. I've marked this as a bug because it seems historically using the task identifier was also supported.

https://github.com/microsoft/vscode/pull/156603/files#diff-f77e08d48fa5a43f6cd385c0bac2c04ee2123565ead5f0f4b60e23c8af821b76R403

[roblourens]

I think I have this set up correctly with the task provider sample. But when I run the runTask command, it just pops up the task picker

Same whether I pass the task name or task property from the definition. I also don't really understand how the task property is special since that doesn't seem to show up in the dts

[vscodenpa]

This bug has been fixed in the latest release of VS Code Insiders!

@ivankravets, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 2c80125 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[connor4312]

If I understand, the latter example from the reporter should be the one that worked, selecting the task by its definition. The first "this code works" example should not actually have worked. I happened to have a 1.68 stable still on my system and verified that Insiders and 1.68 now match this behavior, so the regression was fixed.

[ivankravets]

I've just tested the latest Insiders build and everything works as expected. Thanks for the fix! 🙏