Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check file type& file size in remote before fetching (large) files #158317

Closed
ultranity opened this issue Aug 12, 2022 · 3 comments
Closed

check file type& file size in remote before fetching (large) files #158317

ultranity opened this issue Aug 12, 2022 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-io File I/O remote Remote system operations issues

Comments

@ultranity
Copy link

ultranity commented Aug 12, 2022

vscode will fetch the remote file once you select it, but if the file is very large vscode will hang during the downloading process, and only results in a warning of "The file will not be displayed in the editor because it is either binary or uses an unsupported text encoding.", this behavour may not be what user want as described in microsoft/vscode-remote-release#6517 and microsoft/vscode-remote-release#4696. And even worse the downloading thread will not be canceled even if user close the file tab.

vscode should check the file type&size in the server side, and start fetch file only after user choose to "open it anyway"

@ultranity
Copy link
Author

ultranity commented Aug 12, 2022

also see #152492 and #57585

@tanhakabir tanhakabir transferred this issue from microsoft/vscode-remote-release Aug 16, 2022
@tanhakabir tanhakabir added remote Remote system operations issues file-io File I/O labels Aug 16, 2022
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 17, 2022
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2022
@bpasero
Copy link
Member

bpasero commented Aug 17, 2022

#152492 👍

@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-io File I/O remote Remote system operations issues
Projects
None yet
Development

No branches or pull requests

4 participants