Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the find in selection button into a filters dropdown #158598

Closed
Tyriar opened this issue Aug 19, 2022 · 3 comments
Closed

Move the find in selection button into a filters dropdown #158598

Tyriar opened this issue Aug 19, 2022 · 3 comments
Assignees
Labels
debt Code quality issues editor-find Editor find operations

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2022

Current:

image

Proposed:

image

When a filter is non-default:

image

Find in selection behaves a little strangely currently as it's enabled when there is no selection, we could disable the dropdown entry in this case.

We can also expand this filter to include find in commands/strings/brackets in the future so it's not just a single entry. @hediet is there a feature request for this you could link?

@hediet
Copy link
Member

hediet commented Aug 22, 2022

No known feature request for this.

@miguelsolorio
Copy link
Contributor

I believe we had previously discussed this in #14836 (comment)

@rebornix rebornix added editor-find Editor find operations debt Code quality issues labels Aug 30, 2022
@amunger
Copy link
Contributor

amunger commented Dec 14, 2022

duplicate of #144851

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues editor-find Editor find operations
Projects
None yet
Development

No branches or pull requests

5 participants