Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: task reconnection enabled by default #158787

Closed
3 tasks done
meganrogge opened this issue Aug 22, 2022 · 4 comments
Closed
3 tasks done

Test: task reconnection enabled by default #158787

meganrogge opened this issue Aug 22, 2022 · 4 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Aug 22, 2022

Refs #117408

Authors: @meganrogge @Tyriar

Complexity: 3

Create Issue


Watch tasks will now be reconnected to on window reload by default.

Good examples are the VS Code - Build task and xterm.js watch task. Both can be activated via the command palette or Ctrl/Cmd+Shift+B.

Also try:

  • killing the terminals and running the task again
  • the problems update
  • terminal statuses update
  • restarting VS Code (closing the window and reopening it) does NOT bring back the tasks
  • disabling it with task.reconnection

Known issue:

@meganrogge meganrogge added this to the August 2022 milestone Aug 22, 2022
@bamurtaugh
Copy link
Member

bamurtaugh commented Aug 23, 2022

In case it helps others, I found the precise setting name to be "task.experimental.reconnection".

@weinand
Copy link
Contributor

weinand commented Aug 23, 2022

@meganrogge "Task reconnection" is a great feature and works very well.

I'm not sure whether #158886 is really related to reconnect or just a random find...

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

@bamurtaugh it's actually task.reconnection on the latest version, which may have been released just after your comment

@bamurtaugh
Copy link
Member

Thanks @Tyriar, I see the updated name now!

@bamurtaugh bamurtaugh removed their assignment Aug 23, 2022
@andreamah andreamah removed their assignment Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants