Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad terminal rendering with large font size on high dpi screen #158961

Closed
mjbvz opened this issue Aug 23, 2022 · 1 comment
Closed

Bad terminal rendering with large font size on high dpi screen #158961

mjbvz opened this issue Aug 23, 2022 · 1 comment
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 23, 2022

Testing #158833

  1. On a high dpi screen (tested on MacBook Pro)
  2. Set "terminal.integrated.fontSize": 60

bug

This renders incorrectly (and slowly) on the high dpi screen:

Screen Shot 2022-08-23 at 11 30 13 AM

It renders as expected on a 1x res screen:

Screen Shot 2022-08-23 at 11 30 15 AM
@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

I think you're hitting an incarnation of #158876, where you're filling the texture atlas to its capacity in a single viewport so some glyphs get overwritten.

/duplicate

@Tyriar Tyriar closed this as completed Aug 23, 2022
@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @mjbvz @vscodenpa