Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text editor insert snippet API #15952

Closed
jrieken opened this issue Nov 23, 2016 · 6 comments
Closed

text editor insert snippet API #15952

jrieken opened this issue Nov 23, 2016 · 6 comments
Assignees
@jrieken
Labels
api feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2017

Comments

@jrieken
Copy link
Member

jrieken commented Nov 23, 2016

Since we have now a SnippetString it would also be beneficial to allow snippets to inserted into the editor. Similar to TextEditor.edit we should have something that allows inserting a snippet string and bringing the editor into snippet mode.
@jrieken jrieken self-assigned this Nov 23, 2016
@jrieken jrieken added api feature-request Request for new features or functionality labels Nov 23, 2016
@jrieken jrieken mentioned this issue Nov 23, 2016
Closed
@jrieken jrieken added this to the January 2017 milestone Dec 9, 2016
@joelday
Copy link
Contributor

joelday commented Dec 16, 2016 •
edited
Loading

@jrieken https://github.com/joelday/vscode/commit/38a3a1a23930605643ac186b5ca062ca5d881252

I have no idea if this works and I hit a bunch of walls trying to test it. How far off am I?

@jrieken
Copy link
Member Author

jrieken commented Dec 20, 2016

looking not too bad. keep going

@joelday
Copy link
Contributor

joelday commented Dec 20, 2016

@jrieken Thanks! Is there a workflow you would recommend for running/debugging/testing?

@joelday joelday mentioned this issue Dec 20, 2016
Merged
@jrieken jrieken added the verification-needed Verification of issue is requested label Jan 23, 2017
@jrieken jrieken closed this as completed Jan 23, 2017
@jchannon
Copy link

Is #17628 the way to make this happen?

@jrieken
Copy link
Member Author

jrieken commented Jan 23, 2017

yeah. #17628 is already in master and will be part of our Jan release

@joelday
Copy link
Contributor

joelday commented Jan 23, 2017

So excited to use it in docthis!

@aeschli aeschli added the verified Verification succeeded label Jan 26, 2017
This was referenced Jan 26, 2017
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
4 participants
@jchannon @joelday @jrieken @aeschli