Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.colorCustomizations for window.activeBorder & window.inactiveBorder not working #160159

Closed
pasisavolainen opened this issue Sep 6, 2022 · 1 comment
Assignees

Comments

@pasisavolainen
Copy link

Type: Bug

settings.json:

{
    "workbench.colorTheme": "Default Dark+",
    "window.titleBarStyle": "custom",
    "workbench.colorCustomizations": {
        "window.titleBarStyle": "custom",
        "window.activeBorder": "#00ff4c",
        "window.inactiveBorder": "#2d03eb"
    },
}

Neither active/inactive border colors work. Both August-22(1.71)/Insiders versions affected. I'm pretty sure I saw the colors working in version I had installed previous to August (Probably 1.70).

VS Code version: Code - Insiders 1.72.0-insider (d17726f, 2022-09-05T05:18:01.077Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) undefined
Memory (System) 31.73GB (1.56GB free)
Process Argv --crash-reporter-id aed4eaaa-cf87-4b6e-bb60-1373c532c8e7
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30557514
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
pylanb8912:30522163
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pylantcb52:30558418

@aeschli aeschli assigned bpasero and unassigned aeschli Sep 6, 2022
@bpasero
Copy link
Member

bpasero commented Sep 6, 2022

Support for window border was pulled out for Windows beginning with 1.71.x version. We enabled window control overlays and window borders do not work well in combination. Besides, borders were never fully working depending on window zoom levels and screen DPI. As such, there is #153222 for supporting a native window border from the OS that is not done by CSS from inside the window.

@bpasero bpasero closed this as completed Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants