Test Search Tree

[andreamah]

Refs #20224, #161545

• macOS @lszomoru
• linux @karthiknadig
• windows @bamurtaugh

Complexity: 3

Create Issue

---

Set up:

Make sure you're on the latest version of insiders.

Testing:

We can now see search results in a tree view from within the Search Viewlet.

To see this, click on the magnifying glass on the activity bar (on the left by default) and search for something (shows results from the open workspace(s) plus any loose open files). The button to toggle the search file tree is at the top of the viewlet. See the GIF below for reference

Please try testing it with different files/folders open in the editor. Test the tree view with different folder structures + etc. and make sure that the list view also still works as expected.

Here are a couple of things that I'd like you to particularly test.

Basic Search and Replace

When you perform a search in either view, the results should be what you expect them to be. Try also using search + replace to see if that still works. Try selecting multiple results at once and act upon them (dismiss or replace) to see if multiselect still works. Double-check that you can't get a result to appear twice.

Test Search for Really Nested File

Try searching (and replacing) a file that is nested in a bunch of folders to see if it works and performance is still acceptable.

Tree Compression

When a folder is the only child of another folder (and so on), the nodes should be compressed.

Test Single and Multi-root

Try searching in single and multi-root workspaces to see if the list and tree views work.

Test Collapse/Expand

Ensure that the collapse/expand action (triggers when pressing the collapse/expand button on the top left corner) is correct depending on the state of the nodes. See the GIFs for guidance.

Single-root

In Tree View

Collapses the file nodes. If this is satisfied already, collapses everything. If this is satisfied, expands everything.

In List View

Collapses all if anything is expands. Expands all if everything is collapsed.

Multi-root

In Tree View

Collapses the file nodes. If this is satisfied already, collapses all children of a root folder. If satisfied already, collapses everything. If this is satisfied, expands everything.

In List View

Collapses the file nodes, then collapses the roots, then expands all.

Test setting for default search view.

Toggle the setting for search.defaultViewMode to set a default view type for search results and ensure that you see the correct view when opening the editor in a new workspace. Note that reloading in the same workspace will persist the view type.

[karthiknadig]

Nice work!!!

[lszomoru]

Great job 🚀