Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: l10n-dev & l10n packages #161870

Closed
2 tasks done
TylerLeonhardt opened this issue Sep 26, 2022 · 3 comments
Closed
2 tasks done

Test: l10n-dev & l10n packages #161870

TylerLeonhardt opened this issue Sep 26, 2022 · 3 comments

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Sep 26, 2022

Refs: #82595

Complexity: 4

Create Issue


Goals

The goal of this test plan item is to explore what a non-Microsoft user will have to go through to support localization in their extension. The prediction is that most extensions won't have an entire team of translators at the ready translating strings... and instead an extension will need to crowd source a lot of this.

I have added a sample to vscode-extension-samples that demonstrates how an extension might do this by introducing the main components of localization in the README and providing some localized strings checked in to the repo. I want you to:

  • Read the README to see if it makes sense (run any commands that it says to run)
  • Try adding new code to the extension/package.json that introduces more strings to translate. Try running the l10n-dev tooling to see that these get picked up.

Setup

In https://github.com/microsoft/vscode-extension-samples/tree/tyler/add-l10n-extension-sample I have added a new l10n-sample.

  • Clone this repo and checkout that branch
  • open the l10n-sample folder in vscode insiders
  • You can run the extension in Japanese to get Japanese strings... or English for any other language

Resources

Don't speak another language? No problem. Use Pseudo Language! The language code is qps-ploc so you should be able to save a package.nls.qps-ploc.json and a bundle.l10n.qps-ploc.json and throw the strings through http://www.pseudolocalize.com/ to mimic speaking another language 😉

@dbaeumer
Copy link
Member

@TylerLeonhardt parts of the testing is blocked due to #161945

@joyceerhl
Copy link
Collaborator

Must extensions now have globally unique localization keys?

@joyceerhl joyceerhl removed their assignment Sep 27, 2022
@TylerLeonhardt
Copy link
Member Author

Must extensions now have globally unique localization keys?

No. The same string will be used in those cases.... unless they have different comments because the new key for a string is:

message/commentcommentcomment

@dbaeumer dbaeumer removed their assignment Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants