Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: flow for missing Edit Sessions enablement when using Continue On from web to desktop #161872

Closed
3 tasks done
joyceerhl opened this issue Sep 27, 2022 · 3 comments
Closed
3 tasks done

Comments

@joyceerhl
Copy link
Collaborator

joyceerhl commented Sep 27, 2022

Refs #161266

Authors: @joyceerhl

Complexity: 3

Create Issue


Background

Previously Edit Sessions had to be manually enabled across each VS Code client (web, desktop, different machines). This caused issues if you were using Continue On from web to desktop and had not yet enabled Edit Sessions in desktop, because the desktop instance would not have Edit Sessions enabled, and so your changes would silently fail to restore in the destination. There is now a flow to onboard users to Edit Sessions if they move from web to desktop and have not yet enabled Edit Sessions in VS Code desktop.

Verification

  1. Turn off Edit Sessions on your desktop machine if you were signed in before, either from the account menu or using the Turn off Edit Sessions command in the palette
  2. Open a GitHub or Azure Repos repo in https://insiders.vscode.dev
  3. Make some uncommitted changes
  4. Select Continue Working On > Clone Locally or Continue Working On > Reopen on the Desktop
  5. VS Code should launch on the desktop
  6. You should get a quickpick prompting you to turn on Edit Sessions in desktop
  7. If you hit escape, a badge will now appear in the accounts menu which says 'Check for pending edit sessions' on hover
  8. Click on the Turn On Edit Sessions... item in the accounts menu and sign in with Microsoft or GitHub
  9. Your edits from step 3 should now appear
  10. Also verify that the quickpick and badge do not appear unexpectedly, e.g. if you use Continue On and don't have any working changes
@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2022

I am blocked on #161932
I can continue testing after that gets resolved for me :)

@TylerLeonhardt
Copy link
Member

This worked sooo well and probably will convince me to use GitHub Repos in Desktop more often!

@isidorn
Copy link
Contributor

isidorn commented Sep 29, 2022

I can not get pass #162386
However closing this test plan item since the other two testers tested it, and I can continue testing once I figure out how to get pass #162386

@isidorn isidorn closed this as completed Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants