Terminal hover positioning is unfriendly

[jrieken]

• have a long'ish link, like echo https://github.com/microsoft/vscode/pull/162335
• mouse-hover over the number
• 🐛 the link hover appears left aligned, ignores my mouse x-coordinate, and forces me to move the cursor into it (which can be finicky)

Screen.Recording.2022-09-29.at.14.21.44.mov

[Tyriar]

The terminal does exactly what the editor does:

[daviddossett]

Do we know if there's a good reason we haven't respected the mouse position in the editor case? Seems like it would be a good idea to update both if there isn't one.

[Tyriar]

@daviddossett these are general editor hovers rules I think, for example it works well here as you read the symbol and info is directly above:

Not sure about the decision that went into that, but it's probably something around keyboard interaction being the typical way to trigger the hovers, which doesn't apply as much to links.

[alexdima]

Do we know if there's a good reason we haven't respected the mouse position in the editor case? Seems like it would be a good idea to update both if there isn't one.

The reason was, as @Tyriar mentioned, to align the hover with the current word / symbol being hovered. Over the years, we've added a range property to a hover result, where a hover provider can express what range their hover applies to, and we moved to use that. Most of the times, that range is something sensible, like the current word/symbol. But I agree that this doesn't work very well if the range is a lot larger, if it begins far away from the mouse position or on a wrapped line, etc. This came up a lot over the years, I'll look into improving things.

[alexdima]

The editor positioning is now improved via #163970 , let's keep this issue around to track the terminal hover positioning.

[legomushroom]

Was able to repro this today on stable 1.95.3(f1a4fb) so the issue still exists.