Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish language pack recommender doesn't work on macOS #163458

Closed
rzhao271 opened this issue Oct 12, 2022 · 0 comments · Fixed by #159958
Closed

Spanish language pack recommender doesn't work on macOS #163458

rzhao271 opened this issue Oct 12, 2022 · 0 comments · Fixed by #159958
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
November 2022

Comments

@rzhao271
Copy link
Contributor

  1. Ensure that argv.json doesn't have a locale key-value pair.
  2. Ensure the VS Code Spanish language pack isn't already installed.
  3. Set macOS to use the Español (Latinoamérica) language.
  4. Open VS Code.
  5. 🐛 VS Code isn't in Spanish.

If one repeats the steps with Français (Canada) or Português (Brasil), VS Code starts up in French and Portuguese, respectively. With Español (Latinoamérica), app.getLocale() returns es-419, and the extra country code confuses the recommender.

I plan on fixing this issue as part of the getSystemLocale PR.

CC @TylerLeonhardt
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X labels Oct 12, 2022
@rzhao271 rzhao271 self-assigned this Oct 12, 2022
@rzhao271 rzhao271 added this to the October 2022 milestone Oct 12, 2022
@rzhao271 rzhao271 mentioned this issue Oct 12, 2022
Merged
2 tasks
@rzhao271 rzhao271 modified the milestones: October 2022, November 2022 Oct 21, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 14, 2022
@meganrogge meganrogge added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Pass display language as a locale to Electron microsoft/vscode
3 participants
@rzhao271 @meganrogge @vscodenpa