Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand PickList to support Images or other Icon Fonts #16445

Closed
alefragnani opened this issue Dec 3, 2016 · 4 comments
Closed

Expand PickList to support Images or other Icon Fonts #16445

alefragnani opened this issue Dec 3, 2016 · 4 comments
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@alefragnani
Copy link

Today, you are able to embed icons in the text of the PickList items using Octicons, via $(icon-name).

It would be a great addition to support Images, like in ThemableDecorationRenderOptions.gutterIconPath, or other Icon Fonts like FontAwesome, FontMfizz, etc.

Thanks in advance.

@bpasero
Copy link
Member

bpasero commented Oct 10, 2019

@misolori didn't we do this with the icon font?

@miguelsolorio
Copy link
Contributor

@bpasero not yet, but soon you will be able to use all of our icons (Octicons + product) in the quick pick.

What this issue is asking for is to use other icons, like FontAwesome. In that case I'm closing this in favor of #79130 as that will allow you to do that.

@miguelsolorio miguelsolorio added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
@alefragnani
Copy link
Author

@misolori @bpasero the main request was to use Images (like in ThemableDecorationRenderOptions.gutterIconPath and TreeItem.iconPath supports), basicaly because I would like to reflect in the PickList the same images that can be used in gutter and side bar, from my Bookmarks and Project Manager extensions. Without that, I have to look for similar icons, which is not a perfect scenario.

But, supporting a wider range of icons (and customizations), like you did with the vscode-icons repo is a great step in the right direction.

Thanks 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

4 participants