Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reordering changes in update-localization PRs #164459

Closed
aeschli opened this issue Oct 24, 2022 · 1 comment · Fixed by #164920
Closed

Avoid reordering changes in update-localization PRs #164459

aeschli opened this issue Oct 24, 2022 · 1 comment · Fixed by #164920
Assignees
Labels
debt Code quality issues l10n-platform Localization platform issues (not wrong translations)
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Oct 24, 2022

I've reviewed/approved a couple update-localization PRs (e.g. microsoft/vscode-loc#1118) and observed that there's always a few changes just due to reordered properties. E.g. dist/preview/documentRenderer in microsoft/vscode-loc@751b350
Would be great if we can avoid these, to keep the number of changes small and simplify the reviewing.

@TylerLeonhardt TylerLeonhardt added debt Code quality issues l10n-platform Localization platform issues (not wrong translations) labels Oct 24, 2022
@TylerLeonhardt TylerLeonhardt added this to the November 2022 milestone Oct 24, 2022
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Oct 28, 2022

Fixed in ^^^ keep in mind that this change won't be used until around the 17th of Nov.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues l10n-platform Localization platform issues (not wrong translations)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants