Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Workspace trust setting indicators in the Settings editor #164477

Closed
3 tasks done
rzhao271 opened this issue Oct 24, 2022 · 1 comment
Closed
3 tasks done

Test: Workspace trust setting indicators in the Settings editor #164477

rzhao271 opened this issue Oct 24, 2022 · 1 comment

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Oct 24, 2022

Refs: #157564

Complexity: 3

Authors: @rzhao271, @sandy081

Create Issue


The look of workspace restricted settings is now different in the Settings editor.

  1. Open a restricted workspace.
  2. In the Manage Workspace Trust view, click on the part that says "X workspace settings aren't applied".
  3. The Settings editor should show up with the Workspace tab opened and the restricted settings visible.
  4. The restricted settings should have an indicator on them. The indicator currently has a warning icon on it to be extra noticeable.
  5. A user should be able to change the setting value of a restricted setting and have the new value reflected in the Settings editor. The JSON file should also be updated with the new value. However, the setting in the JSON file should have a warning on it also saying that the setting cannot be applied in an untrusted workspace.
  6. Use a screenreader to focus onto the restricted setting in the Settings editor. Screenreaders currently cannot focus onto the indicators themselves, but when they focus onto the setting, a paraphrased version of the indicator information should be read out.
@rzhao271 rzhao271 added this to the October 2022 milestone Oct 24, 2022
@ghost ghost assigned digitarald, lramos15 and aeschli Oct 25, 2022
@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2022

Works well, also tested with the Orca screenreader in Ubuntu.

@aeschli aeschli removed their assignment Oct 25, 2022
@gregvanl gregvanl assigned gregvanl and unassigned lramos15 Oct 25, 2022
@digitarald digitarald removed their assignment Oct 25, 2022
@gregvanl gregvanl removed their assignment Oct 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants