Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with activating onStartupFinished extensions with a timeout #164593

Open
joyceerhl opened this issue Oct 25, 2022 · 2 comments
Open

Experiment with activating onStartupFinished extensions with a timeout #164593

joyceerhl opened this issue Oct 25, 2022 · 2 comments
Assignees
Labels
extension-activation Issues related to extension activation feature-request Request for new features or functionality perf
Milestone

Comments

@joyceerhl
Copy link
Contributor

Right now we do it right on startup, and there might not be an immediate user gain if an extension moves from * to onStartupFinished.

@joyceerhl joyceerhl self-assigned this Oct 25, 2022
@joyceerhl joyceerhl added this to the Backlog milestone Oct 25, 2022
@joyceerhl joyceerhl added extension-activation Issues related to extension activation feature-request Request for new features or functionality labels Dec 6, 2022
@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2023

Should this use an idle callback instead of setTimeout?

@joyceerhl
Copy link
Contributor Author

It seems we can't use idle callbacks:

  • idle callbacks are only available in a window context, so using runWhenIdle falls back to setTimeout0 in this context
  • the api docs say that we should avoid using idle callbacks for tasks which take an unknown time to run, and extension activation times do significantly vary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-activation Issues related to extension activation feature-request Request for new features or functionality perf
Projects
None yet
Development

No branches or pull requests

2 participants