Disabling Proxy support does not disable proxy agent redirection

[cheenamalhotra]

• VS Code Version: Latest
• OS Version: Windows 11

Steps to Reproduce:

1. Set HTTP_PROXY env variable to garbage value.
2. Start VS Code and set "http.proxySupport": "off" in settings.json
3. Make an HTTP Request (in my case I tested authorization with azurecore provider (similar to microsoft authenticator provider) - from Azure Data Studio)
4. Notice HTTP request will fail.

Expected: Since http.proxysupport is OFF, authentication should not use proxy URL.

Explanation

VSCode should not send Proxy URL in request if proxy support is disabled. As there is no other way to override these settings and skip any injected HTTP_PROXY env variables if users don't want to use Proxy. The Proxy agent set in code despite this proxy support turned "off" causes authentication failures when proxy is not expected to play a role.

I have also tried to use startup params from here, but they don't work either: https://code.visualstudio.com/docs/setup/network#_proxy-server-support

Code Issue

I believe this code is responsible to set Proxy Agent:

vscode/src/vs/platform/request/node/requestService.ts

Lines 83 to 93 in 3df5eee

	const agent = options.agent ? options.agent : await getProxyAgent(options.url || '', env, { proxyUrl, strictSSL });
	options.agent = agent;
	options.strictSSL = strictSSL;
	if (this.authorization) {
	options.headers = {
	...(options.headers || {}),
	'Proxy-Authorization': this.authorization
	};
	}

I think all these 3 settings (agent, strictSSL, proxy headers) should be set only when proxy support is enabled.

[Charles-Gagnon]

I believe this is because extensions use a different stack for handling requests - so the settings in VS Code core don't apply to them automatically.

See #12588

[cheenamalhotra]

I was able to make it work in ADS by updating code to what I mentioned above.
Also, yes, I'm testing ADS, but since codebase in src/vs/platform that's why I brought it up since this issue applies to VSCode core design.

[chrmarti]

"http.proxySupport": "off" only affects extensions.

[fxzxmic]

I don't know if I need to start a new issue, but my question is: Why doesn't vscode support ALL_PROXY environment variable?

[cheenamalhotra]

cc @chrisdias