Crash when closing current macOS native tab

[chrmarti]

Type: Bug

VS Code crashes when I close the current macOS native tab.

VS Code version: Code - Insiders 1.74.0-insider (Universal) (493a541, 2022-12-02T05:25:16.689Z)
OS version: Darwin arm64 22.1.0
Modes:
Sandboxed: Yes
Remote OS version: Linux arm64 5.15.49-linuxkit

System Info

Item	Value
CPUs	Apple M1 Max (10 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	19, 8, 5
Memory (System)	64.00GB (1.32GB free)
Process Argv	--log debug
Screen Reader	no
VM	0%

Item	Value
Remote	Dev Container
OS	Linux arm64 5.15.49-linuxkit
CPUs	unknown (5 x 0)
Memory (System)	7.67GB (6.46GB free)
VM	0%

Extensions (41)

Extension	Author (truncated)	Version
openmatchingfiles	bca	0.5.2
unique-lines	bib	1.0.0
regex	chr	0.4.0
vscode-eslint	dba	2.2.6
vscode-npm-script	eg2	0.3.29
copilot	Git	1.61.7372
remotehub	Git	0.46.0
vscode-pull-request-github	Git	0.55.2022120109
gitlab-workflow	Git	3.57.2
rest-client	hum	0.25.1
template-string-converter	meg	0.6.0
vscode-azureresourcegroups	ms-	0.5.6
vscode-azurevirtualmachines	ms-	0.6.2
vscode-docker	ms-	1.23.1
vscode-language-pack-de	MS-	1.74.11300928
vscode-kubernetes-tools	ms-	1.3.11
vscode-jupyter-cell-tags	ms-	0.1.6
vscode-jupyter-slideshow	ms-	0.1.5
remote-containers	ms-	0.266.0
remote-ssh	ms-	0.92.0
remote-ssh-edit	ms-	0.84.0
remote-wsl	ms-	0.72.0
vscode-remote-extensionpack	ms-	0.23.0
azure-account	ms-	0.11.2
azurecli	ms-	0.5.0
hexeditor	ms-	1.9.9
remote-explorer	ms-	0.0.2
remote-repositories	ms-	0.24.0
remote-server	ms-	0.1.2022120118
test-adapter-converter	ms-	0.1.6
vscode-github-issue-notebooks	ms-	0.0.127
vscode-selfhost-test-provider	ms-	0.3.10
vscode-yaml	red	1.10.1
rust-analyzer	rus	0.4.1305
crates	ser	0.5.10
eval	Sto	0.0.6
vscode-open-in-github	sys	1.17.0
even-better-toml	tam	0.19.0
non-github-remote-source-provider	und	0.0.1
vscode-lldb	vad	1.8.1
intellicode-api-usage-examples	Vis	0.2.6

[chrmarti]

It does not crash when I close any native tab other than the current one.

[chrmarti]

Now it no longer occurs. Let me know if there is anything I should try to reproduce.

[bpasero]

Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!

[chrmarti]

It started again after I installed an update of VS Code Insiders. The dumps folder looks like the dumps didn't finish, I'll send you the files by email:

-rw-------  1 chrmarti  staff  152 Dec  5 16:09 tmp/settings.dat

tmp/attachments:
total 0

tmp/completed:
total 0

tmp/new:
total 0

tmp/pending:
total 8104
-rw-------@ 1 chrmarti  staff   580160 Dec  5 16:04 3fab7360-f433-4ba1-9a23-2dbc28b09e9c.dmp
-rw-------@ 1 chrmarti  staff  1479296 Dec  5 16:09 5fa54a8b-7016-42f4-8b7b-b3fcb1514f57.dmp
-rw-------@ 1 chrmarti  staff  1501024 Dec  5 16:09 6e30106f-b75f-4e2e-ab2c-fa6487142165.dmp
-rw-------@ 1 chrmarti  staff   580560 Dec  5 16:04 d2dd6529-d59b-4fa9-8f97-476051e39684.dmp

[chrmarti]

Also attaching here.
crashdumps-167936.zip

[deepak1556]

Operating system: Mac OS X
                  13.0.1 22A400
CPU: arm64
     10 CPUs

GPU: UNKNOWN

Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash address: 0x7fffffff00000099
Process uptime: 4 seconds

Thread 0 (crashed)
 0  Electron Framework!electron::InspectableWebContents::GetWebContents() const [unique_ptr.h : 288 + 0x0]
     x0 = 0x7fffffff00000001    x1 = 0x000000011b4f0959
     x2 = 0x00000001123109d0    x3 = 0x0000000111e56f80
     x4 = 0x00000001123109d0    x5 = 0x0000000000041c00
     x6 = 0x0000000000000001    x7 = 0x0000000000000001
     x8 = 0x0000000111e55ef0    x9 = 0x000000011b4f0959
    x10 = 0x000000013aa5b329   x11 = 0x00000000000001ff
    x12 = 0x0000000000000159   x13 = 0x000000013a136b60
    x14 = 0x060000011bf9ec75   x15 = 0x000000011bf9ec70
    x16 = 0x000000011bf9ec70   x17 = 0xce52800114dd1a24
    x18 = 0x0000000000000000   x19 = 0x0000000111e56f80
    x20 = 0x00000001123109d0   x21 = 0x7fffffff00000001
    x22 = 0x0000000111e56f80   x23 = 0x000000013963e920
    x24 = 0x0000000000000000   x25 = 0x0000000000041c00
    x26 = 0x0000000000000000   x27 = 0x00000143000000f8
    x28 = 0x000000016b3571a8    fp = 0x000000016b3570f0
     lr = 0x0000000114dd1a58    sp = 0x000000016b3570c0
     pc = 0x0000000114d554e0
    Found by: given as instruction pointer in context
 1  Electron Framework!-[ElectronInspectableWebContentsView viewDidBecomeFirstResponder:] [electron_inspectable_web_contents_view.mm : 268 + 0x4]
     fp = 0x000000016b357140    lr = 0x00000001a77be58c
     sp = 0x000000016b357100    pc = 0x0000000114dd1a58
    Found by: previous frame's frame pointer
 2  CoreFoundation!__CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 0x90
     fp = 0x000000016b357180    lr = 0x00000001a785c074
     sp = 0x000000016b357150    pc = 0x00000001a77be58c
    Found by: previous frame's frame pointer
 3  0xb5138001a785bfb8
    x19 = 0x0000000000000000   x20 = 0x000000016b357448
    x21 = 0x423f17311c5b0009   x22 = 0x0000000000000000
    x23 = 0x0000000000000000   x24 = 0x000000011b4f0959
    x25 = 0xbb6f8001a785c074   x26 = 0x000000016b357180
     fp = 0x000000016b357260    sp = 0x000000016b357190
     pc = 0xb5138001a785bfbc
    Found by: call frame info
 4  CoreFoundation!_CFXRegistrationPost + 0x1b4
     fp = 0x000000016b357c10    lr = 0x00000001a778fbac
     sp = 0x000000016b357270    pc = 0x00000001a785bfbc
    Found by: previous frame's frame pointer
 5  0x18280001a867c728
    x19 = 0x000000013963a510   x20 = 0x00000001123109d0
    x21 = 0x000000013a0b9200   x22 = 0x000000011bf0e698
    x23 = 0x000000011bf0e698   x24 = 0x0000000000000000
    x25 = 0x00000000000000c8   x26 = 0x0000000000000000
    x27 = 0x000000f4000000c5   x28 = 0x000000016b357ef8
     fp = 0x000000016b357c40    sp = 0x000000016b357c20
     pc = 0x18280001a867c72c
    Found by: call frame info
 6  Foundation!-[NSNotificationCenter postNotificationName:object:userInfo:] + 0x54
     fp = 0x000000016b357ca0    lr = 0x0000000116daf1a8
     sp = 0x000000016b357c50    pc = 0x00000001a867c72c
    Found by: previous frame's frame pointer
 7  AppKit!-[NSWindow _realMakeFirstResponder:] + 0x164
    x19 = 0x000000013a817fc0   x20 = 0x000000013a0b9200
    x21 = 0x0000000000000001   x22 = 0x000000013a817fc0
     fp = 0x000000016b357d00    sp = 0x000000016b357cb0
     pc = 0x00000001aab11954
    Found by: call frame info
 8  0x8254000116d45f94
    x19 = 0x000000013a0d2000   x20 = 0xaaaaaaaaaaaaaaaa
    x21 = 0xaaaaaaaaaaaaaaaa   x22 = 0x0000000000000000
    x23 = 0x000000013963e920   x24 = 0x0000000000000000
    x25 = 0x0000000000041400   x26 = 0x0000000000000000
     fp = 0x000000016b357d20    sp = 0x000000016b357d10
     pc = 0x8254000116d45f98
    Found by: call frame info
 9  Electron Framework!content::RenderWidgetHostViewMac::Focus() [render_widget_host_view_mac.mm : 546 + 0x8]
     fp = 0x000000016b357d70    lr = 0x0000000116cc7ec0
     sp = 0x000000016b357d30    pc = 0x0000000116d45f98
    Found by: previous frame's frame pointer
10  Electron Framework!content::WebContentsImpl::RestoreFocus() [web_contents_impl.cc : 4924 + 0x8]
     fp = 0x000000016b357d90    lr = 0x0000000114c7a90c
     sp = 0x000000016b357d80    pc = 0x0000000116cc7ec0
    Found by: previous frame's frame pointer
11  Electron Framework!non-virtual thunk to electron::api::BrowserWindow::OnWindowFocus() [electron_api_browser_window.cc : 305 + 0x0]
     fp = 0x000000016b357e20    lr = 0x0000000114d2f4f4
     sp = 0x000000016b357da0    pc = 0x0000000114c7a90c
    Found by: previous frame's frame pointer
12  Electron Framework!electron::NativeWindow::NotifyWindowFocus() [native_window.cc : 529 + 0x8]
     fp = 0x000000016b357e40    lr = 0x0000000114dd43d0
     sp = 0x000000016b357e30    pc = 0x0000000114d2f4f4
    Found by: previous frame's frame pointer
13  Electron Framework!-[ElectronNSWindowDelegate windowDidBecomeMain:] [electron_ns_window_delegate.mm : 102 + 0x0]
     fp = 0x000000016b357e90    lr = 0x00000001a77be58c
     sp = 0x000000016b357e50    pc = 0x0000000114dd43d0
    Found by: previous frame's frame pointer
14  CoreFoundation!__CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 0x90
     fp = 0x000000016b357ed0    lr = 0x00000001a785c074
     sp = 0x000000016b357ea0    pc = 0x00000001a77be58c
    Found by: previous frame's frame pointer
15  0xe4438001a785bfb8
    x19 = 0x0000000000000000   x20 = 0x000000016b358058
    x21 = 0x423f17311c5b0009   x22 = 0x0000000000000000
    x23 = 0x0000000000000000   x24 = 0x00000001f7be66e3
    x25 = 0x5e638001a785c074   x26 = 0x000000016b357ed0
     fp = 0x000000016b357fb0    sp = 0x000000016b357ee0
     pc = 0xe4438001a785bfbc
    Found by: call frame info
16  CoreFoundation!_CFXRegistrationPost + 0x1b4
     fp = 0x000000016b358960    lr = 0x00000001a778fbac
     sp = 0x000000016b357fc0    pc = 0x00000001a785bfbc
    Found by: previous frame's frame pointer
17  0xa57c0001a867c728
    x19 = 0x000000013963a510   x20 = 0x000000013a893b80
    x21 = 0x000000013a817fc0   x22 = 0x0000000204962510
    x23 = 0x0000000000000000   x24 = 0x0000000000000001
    x25 = 0x0000000202e028c0   x26 = 0x0000000000000000
    x27 = 0x00000001f7be9420   x28 = 0x000000020096b000
     fp = 0x000000016b358990    sp = 0x000000016b358970
     pc = 0xa57c0001a867c72c
    Found by: call frame info
18  Foundation!-[NSNotificationCenter postNotificationName:object:userInfo:] + 0x54
     fp = 0x000000016b358a00    lr = 0x00000001aab1b598
     sp = 0x000000016b3589a0    pc = 0x00000001a867c72c
    Found by: previous frame's frame pointer
19  0xde048001aab1b078
    x19 = 0x000000013a817fc0   x20 = 0x0000000000000001
    x21 = 0x00000001119ab9e0   x22 = 0x0000000000000000
     fp = 0x000000016b358a20    sp = 0x000000016b358a10
     pc = 0xde048001aab1b07c
    Found by: call frame info
20  AppKit!-[NSWindow _makeKeyRegardlessOfVisibility] + 0x34
     fp = 0x000000016b358a40    lr = 0x00000001aab13394
     sp = 0x000000016b358a30    pc = 0x00000001aab1b07c
    Found by: previous frame's frame pointer
21  0x2d1f0001ab1861d0
    x19 = 0x000000016b358ab8   x20 = 0x00000001119ab9e0
     fp = 0x000000016b358a70    sp = 0x000000016b358a50
     pc = 0x2d1f0001ab1861d4
    Found by: call frame info
22  AppKit!__67-[NSWindowStackController _doTabSelectionAndWindowOrderingAtIndex:]_block_invoke + 0xf4
     fp = 0x000000016b358aa0    lr = 0x00000001aaa636cc
     sp = 0x000000016b358a80    pc = 0x00000001ab1861d4
    Found by: previous frame's frame pointer
23  0xeb640001ab185ffc
    x19 = 0x0000000139675050   x20 = 0x0000000000000002
    x21 = 0x000000013ab50150   x22 = 0x00000001119ab9e0
     fp = 0x000000016b358b40    sp = 0x000000016b358ab0
     pc = 0xeb640001ab186000
    Found by: call frame info
24  AppKit!-[NSWindowStackController _doTabSelectionAndWindowOrderingAtIndex:] + 0x2c0
     fp = 0x000000016b358b90    lr = 0x00000001ab184c90
     sp = 0x000000016b358b50    pc = 0x00000001ab186000
    Found by: previous frame's frame pointer
25  0x65040001ab183000
    x19 = 0x00000001119ab9e0   x20 = 0x0000000139675050
    x21 = 0x000000013ab50110   x22 = 0x000000013ab50110
    x23 = 0x0000000000000001   x24 = 0x0000000114c4fcf0
    x25 = 0x0000000000000000   x26 = 0xaaaaaaaaaaaaaaaa
     fp = 0x000000016b358bc0    sp = 0x000000016b358ba0
     pc = 0x65040001ab183004
    Found by: call frame info
26  AppKit!-[NSWindowStackController removeWindow:] + 0xcc
     fp = 0x000000016b358bf0    lr = 0x00000001aac202dc
     sp = 0x000000016b358bd0    pc = 0x00000001ab183004
    Found by: previous frame's frame pointer
27  0x6510001ab1fd33c
    x19 = 0x00000001119ab9e0   x20 = 0x000000013a817fc0
    x21 = 0x0000000000000000   x22 = 0x00000000000000c8
     fp = 0x000000016b358c30    sp = 0x000000016b358c00
     pc = 0x06510001ab1fd340
    Found by: call frame info
28  AppKit!-[NSWindow _finishClosingWindow] + 0x38
     fp = 0x000000016b358c90    lr = 0x00000001aacaf034
     sp = 0x000000016b358c40    pc = 0x00000001ab1fd340
    Found by: previous frame's frame pointer
29  0xce23800114dc83b4
    x19 = 0x00000001119ab9e0   x20 = 0x00000001119aae10
    x21 = 0x0000000000000000   x22 = 0x00000000000001e0
    x23 = 0x000000013988ac28   x24 = 0x000000016b358760
     fp = 0x000000016b358cb0    sp = 0x000000016b358ca0
     pc = 0xce23800114dc83b8
    Found by: call frame info
30  Electron Framework!electron::NativeWindowMac::CloseImmediately() [native_window_mac.mm : 509 + 0x8]
     fp = 0x000000016b358d20    lr = 0x0000000114c7ac60
     sp = 0x000000016b358cc0    pc = 0x0000000114dc83b8
    Found by: previous frame's frame pointer
31  Electron Framework!electron::api::BrowserWindow::CloseImmediately() [electron_api_browser_window.cc : 360 + 0x4]
     fp = 0x000000016b358d60    lr = 0x0000000114c7a288
     sp = 0x000000016b358d30    pc = 0x0000000114c7ac60
    Found by: previous frame's frame pointer
32  Electron Framework!non-virtual thunk to electron::api::BrowserWindow::WebContentsDestroyed() [electron_api_browser_window.cc : 205 + 0x4]
     fp = 0x000000016b358e70    lr = 0x0000000116cb66e8
     sp = 0x000000016b358d70    pc = 0x0000000114c7a288
    Found by: previous frame's frame pointer
33  Electron Framework!void content::WebContentsImpl::WebContentsObserverList::NotifyObservers<void (content::WebContentsObserver::*)()>(void (content::WebContentsObserver::*)()) [web_contents_impl.h : 1515 + 0x0]
     fp = 0x000000016b358ef0    lr = 0x0000000116cb5a5c
     sp = 0x000000016b358e80    pc = 0x0000000116cb66e8
    Found by: previous frame's frame pointer
34  Electron Framework!content::WebContentsImpl::~WebContentsImpl() [web_contents_impl.cc : 1111 + 0xc]
     fp = 0x000000016b358f00    lr = 0x0000000116cb6ab4
     sp = 0x000000016b358f00    pc = 0x0000000116cb5a5c
    Found by: previous frame's frame pointer
35  Electron Framework!content::WebContentsImpl::~WebContentsImpl() [web_contents_impl.cc : 1016 + 0x0]
     fp = 0x000000016b358f50    lr = 0x0000000114d55234
     sp = 0x000000016b358f10    pc = 0x0000000116cb6ab4
    Found by: previous frame's frame pointer
36  Electron Framework!electron::InspectableWebContents::~InspectableWebContents() [unique_ptr.h : 54 + 0x0]
     fp = 0x000000016b358f60    lr = 0x0000000114d55488
     sp = 0x000000016b358f60    pc = 0x0000000114d55234
    Found by: previous frame's frame pointer
37  Electron Framework!electron::InspectableWebContents::~InspectableWebContents() [inspectable_web_contents.cc : 379 + 0x0]
     fp = 0x000000016b358fb0    lr = 0x0000000114cd4290
     sp = 0x000000016b358f70    pc = 0x0000000114d55488
    Found by: previous frame's frame pointer
38  Electron Framework!electron::api::WebContents::~WebContents() [unique_ptr.h : 54 + 0x0]
     fp = 0x000000016b358fc0    lr = 0x0000000114cd451c
     sp = 0x000000016b358fc0    pc = 0x0000000114cd4290
    Found by: previous frame's frame pointer
39  Electron Framework!electron::api::WebContents::~WebContents() [electron_api_web_contents.cc : 993 + 0x0]
     fp = 0x000000016b359020    lr = 0x0000000114ce960c
     sp = 0x000000016b358fd0    pc = 0x0000000114cd451c
    Found by: previous frame's frame pointer
40  Electron Framework!base::internal::Invoker<base::internal::BindState<electron::api::WebContents::Destroy()::$_0, base::WeakPtr<electron::api::WebContents> >, void ()>::RunOnce(base::internal::BindStateBase*) [electron_api_web_contents.cc : 1037 + 0x4]

[deepak1556]

Crash has similar story to electron/electron@c8a3a00 where a re-focus is triggered on a WebContents that is already destroyed. In the commit scenario, it was a race during multiple child windows and in this case it is with native tabs. I will investigate a solution in January milestone.

[bpasero]

👏 , agree January is fine.

[Raboo]

I hit the same bug with my Macbook M1 Pro. Let me know if I need to do anything.

[dmnsgn]

Having the same issue with Version: 1.75.1 on Apple M1 Max. Both when closing with a Cmd+W shortcut or manually clicking the cross button in a tab.

[lewallen]

Today I accidentally triggered "Toggle window tabs bar" from the command palette, and this seems to have made the above problem completely go away (until then, vscode would crash nearly every time I quit the app, for at least the last 6 months or so). Not sure if this is related to the problem or just a coincidence, but maybe it will help someone else too.

[deepak1556]

I am unable to repro the issue on macOS 14.0 and 13.4.1 (c) with latest insiders. Can anyone else still repro the issue with insiders ?

[svipas]

@deepak1556 It still crashes.

MacBook:

• Apple M1 Pro
• Version 13.4.1 (c) (22F770820d)

Insiders:

• Version: 1.81.0-insider
• Commit: fda9726
• Date: 2023-07-25T08:14:58.320Z
• Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 13_4_1) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.81.0-insider Chrome/108.0.5359.215 Electron/22.3.17 Safari/537.36

What I did is I created 3 new windows, closed Insiders, opened it again, and, closed the active window → 💥

It doesn't crash only if I manually switch to windows and then I could close them.

[svipas]

@deepak1556 *.dmp from pending folder and symbolicated-output.log from electron-minidump: crash.zip

BTW: Tried with exploration builds based on Electron 25 and issue is still the same.

[deepak1556]

Thanks for the detailed repro steps, I am able to confirm the issue now.

[svipas]

@deepak1556 I can't believe this is fixed. Amazing work, thank you very much. Please, let me know when I can test it ❤️

[deepak1556]

The fix is now available in our latest insiders https://code.visualstudio.com/insiders, please give it a try.

[svipas]

@deepak1556 It works perfectly 🎉