Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out duplicate events before emitting to clients #169609

Closed
bpasero opened this issue Dec 20, 2022 · 1 comment
Closed

Filter out duplicate events before emitting to clients #169609

bpasero opened this issue Dec 20, 2022 · 1 comment
Assignees
@bpasero
Labels
debt Code quality issues feature-request Request for new features or functionality file-watcher File watcher keep Issues we should not close as out of scope on-testplan
Milestone
October 2023

Comments

@bpasero
Copy link
Member

bpasero commented Dec 20, 2022 •
edited
Loading

We have event deduplication, but there are cases where it does not apply:

  • node.js and parcel watchers are not deduplicating their events
  • multiple node.js watchers are not deduplicating their events

We should see to do simple event deduplication across all watchers to prevent duplicate events from getting emitted.
@bpasero bpasero self-assigned this Dec 20, 2022
@bpasero bpasero added debt Code quality issues file-watcher File watcher labels Dec 20, 2022
@bpasero bpasero mentioned this issue Dec 20, 2022
Closed
@bpasero bpasero changed the title Coalesce events between node.js and parcel watcher Filter out duplicate events before emitting to clients Dec 20, 2022
@bpasero bpasero added the feature-request Request for new features or functionality label Dec 21, 2022
@bpasero bpasero added this to the Backlog milestone Dec 21, 2022
@bpasero bpasero removed their assignment Dec 21, 2022
@bpasero bpasero added the keep Issues we should not close as out of scope label Dec 21, 2022
@bpasero bpasero mentioned this issue Dec 21, 2022
Closed
@bpasero
Copy link
Member Author

bpasero commented Oct 10, 2023

#194776 enables this via new proposed API.

@bpasero bpasero closed this as completed Oct 10, 2023
@bpasero bpasero self-assigned this Oct 10, 2023
@bpasero bpasero modified the milestones: Backlog, October 2023 Oct 10, 2023
@bpasero bpasero mentioned this issue Oct 22, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues feature-request Request for new features or functionality file-watcher File watcher keep Issues we should not close as out of scope on-testplan
Projects
None yet
Milestone
October 2023
Development

No branches or pull requests
2 participants
@bpasero @vscodenpa